Repository navigation
refactor(suggest): take the edit-distance minimum from the builtin min - #1487
Merged
Merged
Conversation
Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
suggest.EditDistancetook the three-way minimum of its Levenshtein cell from a localmin3(a, b, c int)helper. The module is on Go 1.25, where the builtinminaccepts any number of ordered operands, so the one caller now readscur[j] = min(cur[j-1]+1, prev[j]+1, prev[j-1]+cost)andmin3is deleted. Forintoperands the two are identical; no distance changes.How it was verified
tests/suggestTestEditDistancealready pins the distances the suggestions rank on (including the transposition case) and passes unchanged.Checklist
make testandmake lintpass locallyTestEditDistancecovers the behaviour; nothing new needed)min3)changes/unreleased/suggest-builtin-min.changed.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (no count moved)F4,K5) in the body, docs, or changelogLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/c6693d7624634e459fb1c7aac47762ec
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/c6693d7624634e459fb1c7aac47762ec?variant=devin
Requested by: @HuiJun