Skip to content

refactor(semantics): call symbols.AnnotatesOthers directly instead of through a private alias - #1490

Merged
HuiJun merged 1 commit into
developfrom
refactor/annotates-others-alias
Oct 25, 2026
Merged

HuiJun merged 1 commit into
developfrom
refactor/annotates-others-alias

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

What and why

internal/semantic/semantics had a private annotatesOthers(decl) whose body was return symbols.AnnotatesOthers(decl), with a doc comment repeating the exported function's. The five call sites (AboutAnnotationFactsOf, AnnotatedElementsOf, declaredAnnotations, indexAboutUsage in annotations.go, and collectAbout in gather.go) now call symbols.AnnotatesOthers directly — as reflective_memberships.go in the same package and the metamodel, check and libs packages already did — and the alias is deleted. No behaviour changes.

How it was verified

go build ./...        # clean
go vet ./...          # clean
gofmt -l .            # nothing
go test ./...         # ok (122 packages, 0 FAIL; run with -timeout 40m because tests/codegen takes ~9 min under full-suite load)
python3 scripts/changelog.py check

Checklist

  • go build ./..., go vet ./..., gofmt -l ., go test ./... pass locally
  • Tests added or updated for the change — none needed: the existing semantics, check and corpus suites cover every call site and the diff is a pure inlining
  • Documentation extended where it already covers the surface — nothing documents the private helper
  • Changelog entry added as changes/unreleased/annotates-others-alias.changed.md
  • No internal work-item labels in the body, docs, or changelog

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/64808e5eb80e44ff8bf08009c7ab0e8f
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/64808e5eb80e44ff8bf08009c7ab0e8f?variant=devin
Requested by: @HuiJun

… through a private alias

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration
devin-ai-integration Bot marked this pull request as ready for review October 25, 2026 03:48

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@HuiJun
HuiJun merged commit 9b9ea80 into develop Oct 25, 2026
53 checks passed
@HuiJun
HuiJun deleted the refactor/annotates-others-alias branch October 25, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant