Repository navigation
refactor(semantics): call symbols.AnnotatesOthers directly instead of through a private alias - #1490
Merged
Merged
Conversation
… through a private alias Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
internal/semantic/semanticshad a privateannotatesOthers(decl)whose body wasreturn symbols.AnnotatesOthers(decl), with a doc comment repeating the exported function's. The five call sites (AboutAnnotationFactsOf,AnnotatedElementsOf,declaredAnnotations,indexAboutUsageinannotations.go, andcollectAboutingather.go) now callsymbols.AnnotatesOthersdirectly — asreflective_memberships.goin the same package and the metamodel, check and libs packages already did — and the alias is deleted. No behaviour changes.How it was verified
Checklist
go build ./...,go vet ./...,gofmt -l .,go test ./...pass locallychanges/unreleased/annotates-others-alias.changed.mdLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/64808e5eb80e44ff8bf08009c7ab0e8f
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/64808e5eb80e44ff8bf08009c7ab0e8f?variant=devin
Requested by: @HuiJun