Repository navigation
refactor(repl,metamodel): drop test-only forwarders witnessLine, sameName and containsSymbol - #1491
Merged
Merged
Conversation
…Name and containsSymbol No production code called them; the tests now call analysis.WitnessLine, simresults.SameName and slices.Contains directly. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Three production helpers had no production callers and existed only so a test could call them under a local name:
witnessLine(internal/frontend/repl/checker.go) forwarded toanalysis.WitnessLine; onlychecker_test.gocalled it.sameName(internal/frontend/repl/compare.go) forwarded tosimresults.SameName; onlycompare_test.gocalled it.containsSymbol(internal/semantic/metamodel/evaluator.go) was a hand-rolled pointer-equalityslices.Containsover[]*symbols.Symbol; onlyevaluator_test.gocalled it.All three are deleted. The tests are kept as they were and now call the real function (
analysis.WitnessLine,simresults.SameName,slices.Contains), so the same assertions still run over the same inputs. No behaviour changes; thecontainsSymbolhelpers ininternal/exec/runtimeandinternal/semantic/semanticshave production callers and are untouched.How it was verified
go build ./...— cleango vet ./...— cleangofmt -l .— prints nothingpython3 scripts/changelog.py check— okgo test ./...— every packageokexcepttests/codegen, which hit Go's default 10 min package timeout under full-suite load on the machine; rerun alone withgo test -count=1 -timeout 60m ./tests/codegenit passes (ok … 462.395s). The suite does not exercise the changed packages beyondinternal/frontend/replandinternal/semantic/metamodel, bothok.Checklist
go build,go vet,gofmt -l,go test ./...pass locally (see above)changes/unreleased/drop-test-only-forwarders.changed.mdLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/239d2e7a8b954f0bb930a0c6b2b95286
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/239d2e7a8b954f0bb930a0c6b2b95286?variant=devin
Requested by: @HuiJun