Repository navigation
refactor(repl): call nsmerge.MemberName directly instead of a forwarding alias - #1493
Merged
Merged
Conversation
…ing alias Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
memberNameininternal/frontend/repl/declnames.goonly forwarded tonsmerge.MemberName— no argument binding, no conversion. The package already importsnsmergein every file that used the alias and calls its other helpers (SoleNamespace,Chain,BodyMembers) directly, so the alias was one extra hop for readers. The five call sites (declnames.go×2,merge.go,notices.go×2) now callnsmerge.MemberNamedirectly and the alias is deleted. Same function, arguments and result; no behaviour change.How it was verified
Pure refactor; the existing
internal/frontend/repltests cover the call sites (declared-name listing, reopened-namespace merging, replaced/lost-member notices).A first
go test ./...without-timeouthit Go's 10 min default intests/codegen(TestCompiledStepBudgetMatchesInterpreterunder full-suite load); the-timeout 60mrerun above passes it in 691 s.Checklist
make testandmake lintpass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved — no count movedF4,K5) in the body, docs, or changelogLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/371ad3c7f2744fffa364dffd5e04f82e
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/371ad3c7f2744fffa364dffd5e04f82e?variant=devin
Requested by: @HuiJun