Repository navigation
refactor(record): fold shortName into ShortName and drop an orphaned doc comment - #1498
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…doc comment Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
internal/exec/analysis/recordhad an exportedShortNamethat only forwarded to an unexportedshortNameinrecord.go, and above it intarget.goa doc comment for a functionrecordedthat no longer exists in the package.ShortNamenow holds the last-segment logic itself;shortNameis deleted and its two in-package callers (existingInintarget.go, the stem fallback inrecord.go) callShortName.recordeddoc comment is removed.No behaviour change:
record.ShortNamekeeps its signature and semantics, and the only external caller (internal/frontend/repl/record.go) is untouched. Net −6 lines.How it was verified
Eight packages (
cmd/sysml,internal/exec/runtime,internal/exec/smt,tests/{codegen,export,migrate,model,wasm}) hit Go's 10-minute default under the parallel full run on this machine and were re-run together with-count=1 -timeout 60m: allok.Checklist
go build ./...,go vet ./...,gofmt -l .andgo test ./...pass locallyrecordandreplsuites coverShortNamethrough its callerschanges/unreleased/record-short-name.changed.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved — no gate count movedLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/875e99aaa1174aa6999e7dc9b052be0b
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/875e99aaa1174aa6999e7dc9b052be0b?variant=devin
Requested by: @HuiJun