Skip to content

refactor(record): fold shortName into ShortName and drop an orphaned doc comment - #1498

Open
devin-ai-integration[bot] wants to merge 1 commit into
developfrom
refactor/record-short-name
Open

devin-ai-integration[bot] wants to merge 1 commit into
developfrom
refactor/record-short-name

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

What and why

internal/exec/analysis/record had an exported ShortName that only forwarded to an unexported shortName in record.go, and above it in target.go a doc comment for a function recorded that no longer exists in the package.

  • ShortName now holds the last-segment logic itself; shortName is deleted and its two in-package callers (existingIn in target.go, the stem fallback in record.go) call ShortName.
  • The orphaned recorded doc comment is removed.

No behaviour change: record.ShortName keeps its signature and semantics, and the only external caller (internal/frontend/repl/record.go) is untouched. Net −6 lines.

How it was verified

go build ./...        # clean
go vet ./...          # clean
gofmt -l .            # prints nothing
go test ./...         # all packages ok

Eight packages (cmd/sysml, internal/exec/runtime, internal/exec/smt, tests/{codegen,export,migrate,model,wasm}) hit Go's 10-minute default under the parallel full run on this machine and were re-run together with -count=1 -timeout 60m: all ok.

Checklist

  • go build ./..., go vet ./..., gofmt -l . and go test ./... pass locally
  • Tests added or updated for the change — none needed; the existing record and repl suites cover ShortName through its callers
  • Documentation extended where it already covers the surface — no documented surface changes
  • Changelog entry added as changes/unreleased/record-short-name.changed.md, not as an edit to CHANGELOG.md
  • baselines regenerated and make docs-counts run if a gate count moved — no gate count moved
  • No internal work-item labels in the body, docs, or changelog

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/875e99aaa1174aa6999e7dc9b052be0b
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/875e99aaa1174aa6999e7dc9b052be0b?variant=devin
Requested by: @HuiJun

…doc comment

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration
devin-ai-integration Bot marked this pull request as ready for review October 25, 2026 05:20

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant