Skip to content

refactor(runtime): put conditionText's doc comment back on conditionText - #1499

Merged
HuiJun merged 1 commit into
developfrom
refactor/condition-text-doc-comment
Oct 25, 2026
Merged

HuiJun merged 1 commit into
developfrom
refactor/condition-text-doc-comment

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

What and why

conditionText's doc comment ("conditionText renders a condition compactly…") sat directly above qualifiedNameText's own doc comment in internal/exec/runtime/condition.go, so godoc and readers attributed it to qualifiedNameText while conditionText itself had no doc comment. This moves the two lines back onto func conditionText. Comment-only; no code changes. The exported ConditionText forwarder stays, as it is the package API used by internal/translate/codegen/compile.go.

How it was verified

  • go build ./... — clean
  • go vet ./... — clean
  • gofmt -l . — prints nothing
  • python3 scripts/changelog.py check — passes
  • go test ./... — 115 packages ok; cmd/sysml, internal/exec/runtime, internal/exec/smt, tests/codegen, tests/export, tests/model and tests/wasm hit Go's default 10 m package timeout under the parallel run, then re-run alone with -count=1 -timeout 60m:
    • cmd/sysml ok 545.7s
    • internal/exec/runtime ok 329.8s
    • internal/exec/smt ok 346.5s
    • tests/codegen ok 409.2s
    • tests/export ok 156.2s
    • tests/model ok 149.0s
    • tests/wasm ok 91.5s

Checklist

  • go build ./..., go vet ./..., gofmt -l . and go test ./... pass locally (results above); make lint not run for a comment-only move
  • Tests added or updated for the change — not applicable, no behaviour touched
  • Documentation extended where it already covers the surface — not applicable
  • Changelog entry added as changes/unreleased/condition-text-doc-comment.changed.md, not as an edit to CHANGELOG.md
  • baselines regenerated and make docs-counts run if a gate count moved — no count moved
  • No internal work-item labels (waves, slices, F4, K5) in the body, docs, or changelog

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/38a2f421daf54106a0f52b2061900daa
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/38a2f421daf54106a0f52b2061900daa?variant=devin
Requested by: @HuiJun

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration
devin-ai-integration Bot marked this pull request as ready for review October 25, 2026 05:51

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@HuiJun
HuiJun merged commit 44dcd3f into develop Oct 25, 2026
53 checks passed
@HuiJun
HuiJun deleted the refactor/condition-text-doc-comment branch October 25, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant