fix: generalize site footer content - #117
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Responsive design follow-up:
Validation completed at 375px, 768px, and 1440px with no horizontal overflow. |
|
已按项目样式约定继续优化:删除 Footer.module.less(92 行),改由 Bootstrap 5.3 栅格和工具类承担布局、间距、分隔、对齐及响应式展示。已验证 375/768/1440px:无横向溢出;平板两列等分;桌面三列宽度均为 437.33px;开源图书馆仍保留 Catalog / How to Borrow 和原描述。pnpm test 与 CodeQL 均通过。Build-and-Deploy 仍因 Vercel Team fair-use 限额失败。提交:31786fa。 |
| site_footer_description: | ||
| '一个以开源软硬件、公益项目为主题的公益活动品牌,也是一个以「开放式协作」为核心理念的开源社群。', | ||
| footer_description: '一个由社区驱动的图书馆,用于分享知识和故事。开源构建。由慷慨驱动。', |
There was a problem hiding this comment.
| site_footer_description: | |
| '一个以开源软硬件、公益项目为主题的公益活动品牌,也是一个以「开放式协作」为核心理念的开源社群。', | |
| footer_description: '一个由社区驱动的图书馆,用于分享知识和故事。开源构建。由慷慨驱动。', | |
| site_footer_description: | |
| '一个以开源软硬件、公益项目为主题的公益活动品牌,也是一个以「开放式协作」为核心理念的开源社群。', | |
| library_footer_description: '一个由社区驱动的图书馆,用于分享知识和故事。开源构建。由慷慨驱动。', |
| <span className="d-inline-block flex-shrink-0 text-center" aria-hidden="true"> | ||
| 📌 | ||
| </span> | ||
| <span>{t('community_location')}</span> |
There was a problem hiding this comment.
| <span>{t('community_location')}</span> | |
| <address>{t('community_location')}</address> |
Co-authored-by: South Drifter <shiy2008@gmail.com>
Co-authored-by: South Drifter <shiy2008@gmail.com>
Summary
_app.tsxbased on the current routeContext
This follows the reviewer feedback in #116: keep one Footer component and pass route-specific content into it instead of maintaining two independent footer implementations.
Validation
pnpm testpassedgit diff --checkpassedCI=true NEXT_TELEMETRY_DISABLED=1 pnpm exec next build --webpack/,/article/about,/open-library, and/open-library/booksin a local browserClose #115