Skip to content

[core] Remove backslash from path - #24723

Open
wing328 wants to merge 1 commit into
masterfrom
blackslash-path
Open

[core] Remove backslash from path#24723
wing328 wants to merge 1 commit into
masterfrom
blackslash-path

Conversation

@wing328

@wing328 wing328 commented Aug 17, 2026

Copy link
Copy Markdown
Member

fyi @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Normalizes generated operation paths by stripping backslashes in DefaultCodegen. Previously paths kept backslashes (e.g., /fake/path/backslash/GetPetById()); now they are removed (e.g., /fake/path/backslash/GetPetById()), preventing escaped characters from leaking into generated clients and docs.

  • Review notes

    • Implemented in fromOperation by setting op.path = op.path.replace("\\", "").
    • Added an OAS 3.1 petstore path with backslashes and updated Java okhttp-gson-3.1 samples (README.md, docs/FakeApi.md, api/openapi.yaml, FakeApi.java) to show the normalized path.
  • Migration

    • If your API requires literal backslashes in paths, they will now be removed. Avoid backslashes in OpenAPI paths or customize the generator to preserve them.

Written for commit 32296f4. Summary will update on new commits.

Review in cubic

@wing328
wing328 marked this pull request as ready for review August 17, 2026 10:16

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant