Repository navigation
fix(ui): point the prod build at Keycloak on its own origin, /auth - #49
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ui/Dockerfile.prodnow defaultsVITE_KEYCLOAK_URLto/authinstead ofhttp://localhost:8081/auth.Why
Vite bakes
VITE_*into the bundle at build time, and CI builds with the defaults, so every publishedknowledge-provider-uiimage sent the login redirect tolocalhost:8081: the viewer's own machine. On Kubernetes, Keycloak is served at/authon the same host as the UI (/knowledge-provider/). The UI builds its authorize and logout URLs by hand (no keycloak-js), so a relative URL resolves against the page's origin and the browser lands on the right Keycloak. One image works on every host laid out this way, with no per-environment build.A host with Keycloak somewhere else can still pass
--build-arg VITE_KEYCLOAK_URL=....docker-compose.ymlalready passes its own value, so local compose is unchanged.Testing
ui/src/auth/keycloak.js:authorizeUrland the logout URL are${keycloakUrl}/realms/...passed towindow.location.assign, which accepts a relative path.isKeycloakConfiguredonly checks the value is non-empty.main: UI athttps://65.2.99.2.sslip.io/knowledge-provider/, login redirects to/auth/realms/docs-pipeline/....🤖 Generated with Claude Code