Skip to content

Fix code review context during modification - #664

Open
primorLee wants to merge 1 commit into
OpenBMB:chatdev1.0from
primorLee:fix/code-review-regulation-context
Open

Fix code review context during modification#664
primorLee wants to merge 1 commit into
OpenBMB:chatdev1.0from
primorLee:fix/code-review-regulation-context

Conversation

@primorLee

Copy link
Copy Markdown

Summary

  • carry all six CodeReviewComment regulations into CodeReviewModification
  • tell the Programmer to preserve every regulation while addressing the highest-priority comment
  • keep the Default and Human company configurations aligned

Without this context, each review cycle fixes only the surfaced comment and can regress criteria that the next reviewer immediately checks again.

Validation

  • parsed both PhaseConfig.json files with Python json
  • asserted both modification prompts are identical and contain exactly six numbered regulations

Fixes #650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant