Repository navigation
Fix/fill custom algo form - #131
filiperochalopes wants to merge 2 commits into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3198b26e7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name: data.name || '', | ||
| description: data.description || '', | ||
| }); | ||
| updateSelected(key, metadataFields(data)); |
There was a problem hiding this comment.
Preserve duplicate-ID detection when adding canonical metadata
If two configured custom endpoints report the same ID, name and description but different valid canonical URLs, including canonical_url in this patch prevents updateSelected's filter(value, patch) from matching the first row. The second row therefore receives no conflict error, whereas the previous three-field patch detected the duplicate. This matters because MapProject.getAlgoDef selects the first configuration by ID and mergeIntoRowMatchState removes existing candidates with the incoming algorithm_id, so the endpoints can overwrite each other's results. Validate ID/name uniqueness independently of the full metadata patch.
Useful? React with 👍 / 👎.
TL;DR: Populate custom algorithm canonical URLs from discovery metadata and support GET discovery both without and with the
$operation marker. No tracking issue linked.Main Changes
src/components/map-projects/MultiAlgoSelector.jsx(+6/−8)src/components/map-projects/customAlgoMetadata.js(+27/−0)$first, then the original URL if needed.src/components/map-projects/algorithms.jsx(+2/−7)src/components/map-projects/__tests__/customAlgoMetadata.test.js(+73/−0)Key Decisions
canonical_urlfrom discovery metadata.$, then the original URL when the first response is not usable metadata.Verification Checklist
npm test npm run test:integration npm run eslint ./node_modules/.bin/webpack --mode development --env NODE_ENV=development --output-path /path/to/scratch/build