Repository navigation
Conversation
The chip came out with the unified navigation (OpenConceptLab/ocl_online#418). It now links to TBv2 at app.v2.<env>, which keeps working once TBv3 serves app.<env>, or to a configured TBV2_URL; other deployments show no chip. The path mapping moved to appUrls.js with tests, and also carries versioned expansions across. Phones hide the chip and medium widths show only its logo, so the header doesn't wrap beside + and the account button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AaZ4qX4xy8MVN45s1UuhFt
…ing HEAD in TBv2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AaZ4qX4xy8MVN45s1UuhFt
Member
Author
|
Codex review, pass 1 (codex-cli 0.169.0, commit ff84b8e) Verdict: findings, 1 finding(s).
findings.json{
"reviewer": "codex-cli 0.169.0",
"perspective": "defects",
"mode": "full",
"commit": "ff84b8e5",
"verdict": "findings",
"prior": [],
"findings": [
{
"id": "F1.1",
"severity": "P1",
"tag": null,
"file": "src/common/appUrls.js",
"line": 84,
"claim": "Expansion links without an explicit version lose their selected expansion.",
"scenario": "TBv3 supports /orgs/o/collections/c/expansions/e1/concepts/1066 for an implicit HEAD collection. This maps to /orgs/o/collections/c/concepts/1066, opening the default expansion instead of e1 and potentially losing the selected concept. TBv2 can represent the same page at /orgs/o/collections/c/HEAD/expansions/e1/concepts/1066.",
"action": "Insert HEAD when preserving an expansion without an explicit version, as the removed implementation did. Update the test that currently expects the expansion to be discarded.",
"lines_delta": null,
"confidence": "high"
}
]
} |
Member
Author
|
Codex review, pass 2 (codex-cli 0.169.0, commit ead9b7c) Verdict: clean, no findings.
findings.json{
"reviewer": "codex-cli 0.169.0",
"perspective": "defects",
"mode": "verify",
"commit": "ead9b7c2",
"verdict": "clean",
"prior": [
{
"id": "F1.1",
"status": "resolved"
}
],
"findings": []
} |
… props MUI already supplies Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AaZ4qX4xy8MVN45s1UuhFt
Member
Author
|
Simplification review (Claude subagent, Sonnet 5.5, commit ead9b7c) Verdict: findings, 3 finding(s).
findings.json{
"reviewer": "claude subagent",
"perspective": "simplify",
"mode": "full",
"commit": "ead9b7c2",
"verdict": "findings",
"prior": [],
"findings": [
{
"id": "S1",
"severity": null,
"tag": "yagni",
"file": "src/components/common/ClassicOCLLogo.jsx",
"line": 337,
"claim": "The `size` prop has no caller. ClassicTermBrowserButton renders <ClassicOCLLogo /> with no props, so the `size || 18` fallback and the props destructuring are unused flexibility.",
"action": "Drop the prop and hard-code `width={18} height={18}`: `const ClassicOCLLogo = () => (<img src={CLASSIC_LOGO} alt='' width={18} height={18} style={{display: 'block', borderRadius: '3px'}} />);`",
"lines_delta": -1,
"confidence": "high",
"scenario": null
},
{
"id": "S2",
"severity": null,
"tag": "delete",
"file": "src/components/app/ClassicTermBrowserButton.jsx",
"line": 274,
"claim": "`size='medium'` is MUI Chip's default, so it does nothing.",
"action": "Nothing replaces it.",
"lines_delta": -1,
"confidence": "high",
"scenario": null
},
{
"id": "S3",
"severity": null,
"tag": "native",
"file": "src/components/app/ClassicTermBrowserButton.jsx",
"line": 279,
"claim": "The explicit `aria-label` repeats what MUI Tooltip already does. When `title` is a string, Tooltip sets `aria-label` on its child to that title, and here the title is the same translation key.",
"action": "Remove the `aria-label` prop and let Tooltip supply it.",
"lines_delta": -1,
"confidence": "medium",
"scenario": null
}
]
} |
Member
Author
Member
Author
|
@snyaggarwal This brings back the TBv2 cross-link in the header in TBv3. Please merge and deploy if it looks good. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores TBv3's "View in TBv2" chip (closes OpenConceptLab/ocl_issues#3039). It was removed with the unified navigation in #89; TBv2's "View in TBv3" chip still works, so people could go from TBv2 to TBv3 but not back.
What changed from the removed version
app.v2.<env>instead ofapp.<env>, so the link keeps working once TBv3 servesapp.<env>.TBV2_URLsetting, wired likeMAPPER_URL, overrides it. Deployments outside openconceptlab.org show no chip unless it's set, rather than linking to OCL's production TBv2.appUrls.jswith unit tests. It now carries versioned expansions across and drops tabs or resources TBv2 doesn't have (summary, unversioned expansions, references/:id).sm, shows only its logo belowmd, and shows "View in TBv2" frommdup. The tooltip carries the label throughout.Checked
eslintandnpm testas inpr.yml(153 pass).TBV2_URL: chip links from 8 pages (concept, source about and versions, collection version references, versioned expansion concepts, collection summary, org URL registry, search) all landed on the matching page on production TBv2.Deploy: nothing to set for openconceptlab.org environments.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AaZ4qX4xy8MVN45s1UuhFt