Repository navigation
Conversation
…ff for a source version - Version menu (staff, not HEAD): Turn On / Turn Off OCL Semantic Search, with a confirm dialog that names the version and its concept count. It updates the version's match algorithms (adds or removes llm, keeps the rest); the API queues the vector sync. - Version menu (staff, semantic versions): Sync Vectors, the reindex dialog posting sync_vectors, which reruns the sync without changing the setting. - New source version form (staff): an OCL Semantic Search checkbox that starts as HEAD's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… once its task finishes; a semantic-only setting stays so Codex pass 1 on #99: - F1.1: a queued reindex or vector sync kept its menu item disabled until the page reloaded. useQueuedTasks remembers each queued task, and opening a version's (or an expansion's) menu asks the API about it and forgets it once it has finished. Both versions tabs use it. - F1.2: withSemanticSearch(['llm'], true) added es. Only an empty list, or turning off the only algorithm, falls back to es now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
Codex review, pass 1 (codex-cli 0.167.0, commit 0ab6342)Verdict: findings (2 findings)
Response (fixed in f935cf7):
findings.json{
"reviewer": "codex-cli 0.167.0",
"perspective": "defects",
"mode": "full",
"commit": "0ab63425e5cd40eb004201ea5cc5d329a69f3f10",
"verdict": "findings",
"prior": [],
"findings": [
{
"id": "F1.1",
"severity": "P1",
"tag": null,
"file": "src/components/repos/SourceVersionsTab.jsx",
"line": 293,
"claim": "Sync Vectors stays disabled after its task finishes or fails.",
"scenario": "Staff queue a sync and close the result dialog. Its task ID is stored in reindexWip, but nothing clears that entry. Even after processing ends, the menu remains disabled and reports the task as running, preventing a retry after failure until the component is remounted.",
"action": "Clear the cached entry when the task completes or fails, or stop treating a cached task ID as permanent evidence of running work.",
"lines_delta": null,
"confidence": "high"
},
{
"id": "F1.2",
"severity": "P2",
"tag": null,
"file": "src/components/repos/semanticSearch.js",
"line": 11,
"claim": "Creating a version from semantic-only HEAD silently enables token matching.",
"scenario": "HEAD has the valid setting [\"llm\"]. Staff create a version with the default semantic checkbox unchanged. withSemanticSearch([\"llm\"], true) returns [\"es\", \"llm\"], whereas creation previously inherited [\"llm\"]. The fallback adds an algorithm even though the final list would not be empty.",
"action": "Preserve [\"llm\"] when semantic search remains enabled; apply the es fallback only for missing settings or an otherwise empty final list. Add this case to the helper tests.",
"lines_delta": null,
"confidence": "high"
}
]
} |
Member
Author
Codex review, pass 2 (codex-cli 0.167.0, commit f935cf7)Verdict: clean. F1.1 resolved, F1.2 resolved; no new findings. findings.json{
"reviewer": "codex-cli 0.167.0",
"perspective": "defects",
"mode": "verify",
"commit": "f935cf7d6d808b2fe3970244397799a294ac0fcc",
"verdict": "clean",
"prior": [
{
"id": "F1.1",
"status": "resolved"
},
{
"id": "F1.2",
"status": "resolved"
}
],
"findings": []
} |
Member
Author
Simplification review (claude subagent, commit f935cf7)Verdict: 3 optional cuts; none applied, so no commits follow the last Codex pass and no extra check is needed.
No adversarial pass: the PR changes no permission. The API's existing staff checks still decide, and the UI only hides what they would refuse. findings.json{
"reviewer": "claude subagent",
"perspective": "simplify",
"mode": "full",
"commit": "f935cf7d6d808b2fe3970244397799a294ac0fcc",
"verdict": "findings",
"prior": [],
"findings": [
{
"id": "S1",
"severity": null,
"tag": "shrink",
"file": "src/components/repos/SemanticSearchDialog.jsx",
"line": 10,
"claim": "lodash isNumber is imported for one check on the concept count. A plain typeof does the same and drops a dependency import from a new file.",
"scenario": null,
"action": "Replace `isNumber(conceptCount)` with `typeof conceptCount === 'number'` and remove the lodash import.",
"lines_delta": -1,
"confidence": "medium"
},
{
"id": "S2",
"severity": null,
"tag": "shrink",
"file": "src/components/repos/SourceVersionsTab.jsx",
"line": 488,
"claim": "The reindex menu entries carry both `key` and `contentType`, which are identical for concepts and mappings. `syncVectors` already implies the vectors entry, so key and label can be derived. The entries also pass `label` through reindexTarget just to rebuild a string the dialog could pick itself from `syncVectors`/`contentType`.",
"scenario": null,
"action": "Drop `key` from the first two entries and use `key = syncVectors ? 'vectors' : contentType`. Stop passing `label` through reindexTarget and have the dialog derive it, as it did before.",
"lines_delta": -3,
"confidence": "low"
},
{
"id": "S3",
"severity": null,
"tag": "yagni",
"file": "src/components/repos/SemanticSearchDialog.jsx",
"line": 16,
"claim": "The new dialog copies ReindexVersionDialog's whole submit/result/close structure (submitting and result state, response status parsing, success and error Alert, Close button). A shared confirm-and-submit dialog could serve both. Judged only a possible later cleanup, since the two differ in verb and payload.",
"scenario": null,
"action": "Optional: extract a shared confirm/result dialog shell. No change needed for this PR.",
"lines_delta": -30,
"confidence": "low"
}
]
} |
paynejd
marked this pull request as ready for review
November 10, 2026 18:41
snyaggarwal
approved these changes
Nov 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes OpenConceptLab/ocl_online#46
Staff can turn OCL Semantic Search on or off for a source version from TBv3, instead of the CLI's
ocl repo version-update --match-algorithms es,llm. TBv3 uses the API as it is: the change needs no oclapi2 work, and the API already allows these changes for staff only.Version menu (staff only)
PUT <version>/with the version's match algorithms, adding or removingllmand keeping the rest; the API then queues the vector sync. The version's Mapper chip updates without a reload, and an API error shows its message.POST <version>/concepts/indexes/withsync_vectors, which reruns the vector sync without changing the setting, and shows the task id.New source version form (staff only): an OCL Semantic Search checkbox that starts as HEAD's setting, which is the API's default. Unchanged for everyone else: the form sends no
match_algorithms.Re-index and Sync Vectors can run again once their task finishes (from the review, F1.1). Until now, a queued re-index kept its menu item disabled until the page was reloaded.
useQueuedTasksremembers each queued task, and opening a version's or an expansion's menu asksGET /tasks/<id>/and forgets the tasks that have finished. Both versions tabs use it.Not in scope: HEAD's own setting (it stays in the API and the CLI), and access for users who aren't staff (OpenConceptLab/ocl_online#587).
Documentation needed, once this is deployed
docs/source/oclmap/matching-algorithms.md, the OCL Semantic paragraph that says "Only staff accounts can change that setting": say where staff change it. That's the version's menu on the repository's Versions tab in the TermBrowser, or the OCL Semantic Search checkbox when creating a source version.tbv3/tbv3-knowledge-base.md, authoring section, next to "Release (or un-release) a version": add the staff version actions Turn On/Off OCL Semantic Search and Sync Vectors, the create-form checkbox, and that Re-index and Sync Vectors become available again once their task finishes.infrastructure/vectorization.md, "Opting in or out": add the TBv3 route beside the CLI and API ones for creation, later changes and the staff re-run.Checked
npm test(136 pass; new:semanticSearch.test.js,taskState.test.js) and CI's ESLint command.users/jontest4/sources/default-view-test, v1), 21 checks:["es","llm"], 200), saw the Mapper chip appear, ran Sync Vectors (202, task id shown, the item then disabled), turned it off (["es"], 200) and saw the chip go. HEAD's menu has no toggle.["es","llm"]and nosemanticfield. No version was created, and v1 is back to["es"].🤖 Generated with Claude Code