Repository navigation
[apb-timer/dv] Add functional coverage groups for timer, PWM, and IRQ - #3
Open
Raghavan-04 wants to merge 3 commits into
Open
Raghavan-04 wants to merge 3 commits into
Raghavan-04 wants to merge 3 commits into
Conversation
Contributor
Author
|
Hi @briann-bui, Thank you for the detailed feedback! I have updated the PR to address all review points:
All CI checks are passing successfully. Ready for re-review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added SystemVerilog functional coverage module (
timer_cov.sv) bound toapb_timer_wrapperinapb_timer_tb_top.sv.Related issue or proposal
Related to #1
Design notes
timer_covtoapb_timer_wrapperinsideapb_timer_tb_top.svto keep verification logic separated from synthesizable RTL.cg_ctrl): Trackstimer_en,oneshot_en, andpwm_encrossed with prescaler value bins (zero,one,max,mid_range).cg_timer_cfg): Tracks reload vs. compare threshold conditions (compare < reload,compare == reload,compare > reload).cg_irq): Tracks overflow (irq_stat[0]) and compare match (irq_stat[1]) triggers, crossed with mask enables (irq_en).Verification
Static linting executed cleanly via Verilator in Linux GitHub Codespaces:
Checklist