Test on openmm-8.5 - #2183
Conversation
IAlibay
left a comment
There was a problem hiding this comment.
I believe the _cache attribute was renamed to _cache_path with the latest release of openmmforcefields.
Could you update the test accordingly please?
Because we will need to support both new & old versions of openmmforcefields for now, you might have to do a version check on testing that attribute.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2183 +/- ##
==========================================
- Coverage 95.03% 90.26% -4.77%
==========================================
Files 206 206
Lines 20527 20533 +6
==========================================
- Hits 19508 18535 -973
- Misses 1019 1998 +979
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
GPU tests are running here: https://github.com/OpenFreeEnergy/openfe/actions/runs/34223912728 Will approve once they past. |
IAlibay
left a comment
There was a problem hiding this comment.
Can you add a news entry please?
Test on openmm-8.5 following the benchmark results in #1928
LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: yes / no
If yes, please provide details here: No
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin