Repository navigation
ExtractMixin tolerates keyword-only construction difference - #358
Merged
Merged
Conversation
For ExtractMixin moves, a DIFFERENT_CONSTRUCTION guard that fires only because class keywords differ (e.g. affix vs nothing) is downgraded to SAME_CONSTRUCTION. The mixin is a new class that doesn't inherit the composers' keywords. Dataclass declaration, metaclass, and decorator differences still guard. Unblocks 3 more missing_mixin verdicts on agent-comms where one class is a DeclaredFamily member (with affix) and the other is a plain dataclass: HistoricalNativeInput/WakeClaim, Channel/ChannelPreferences, InstalledEvidence/ReportedProblemOrder. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dR7JdknxC8XJJtW8Uh
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
pushed a commit
that referenced
this pull request
Nov 11, 2026
Positional construction is handled at the owner level as a keywording prerequisite (keyword_cure). It should not block the verdict itself for ExtractMixin moves. The owner candidate's _field_order_receipts produces the POSITIONAL_CONSTRUCTION guard with keyword cure; the recipe synthesizer checks owner.keyword_cure before the pick match. Unblocks 5 more missing_mixin verdicts on agent-comms: SessionFacts/ImportBuffer, BusRouteCounts/BusRouteKeys, RouteUnread/CursorRow, FailedTurnEvidence/GoalDerivedContact, HostMemoryHigh/HostResources (last also has DECLARATION_DIFFERS). Combined with PRs #357 and #358: 5 + 3 + 3 + 5 = up to 16 mixin ops. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dR7JdknxC8XJJtW8Uh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For ExtractMixin moves, DIFFERENT_CONSTRUCTION is downgraded to SAME_CONSTRUCTION when the only difference is class keywords (e.g.
affixvs nothing). The mixin is a new class that doesn't inherit keywords. Dataclass declaration, metaclass, and decorator mismatches still guard.What changed
_construction_receiptsnow accepts optionalmoveparametermove is ExtractMixinand all differences are class-keyword-only, produces SAME_CONSTRUCTION instead of DIFFERENT_CONSTRUCTIONmoveto the methodtest_keyword_only_construction_diff_does_not_block_extract_mixinImpact on agent-comms
Unblocks 3 more missing_mixin verdicts where one class has
affixkeyword and the other doesn't:Combined with PR #357 (INHERITED tolerance): 5 original + 3 inherited + 3 keyword = up to 11 mixin ops.
Evidence
6/6 tests green (5 existing + 1 new).
Generated by Claude Code