Repository navigation
flatten_tuple_return handles Return and Starred reader contexts - #360
Merged
Merged
Conversation
_rewrite_reader now handles two more patterns: - Return: `return method()` wraps the flattened result back into a tuple using a walrus: `((_r := method()),) if _r is not None else ()` - Starred: `*method()` in a tuple is a passthrough (no rewrite needed) These unblock most of the 13 zero_one_tuple findings on agent-comms where callers use `return method()` (e.g. RuntimeReference.hidden at runtime_processes.py:310) or tuple spread. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dR7JdknxC8XJJtW8Uh
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two new reader-context handlers for
FlattenTupleReturnOperation:return method()→return ((_r := method()),) if _r is not None else ()— wraps the flattened result back into a tuple so the caller's contract is unchanged*method()passthrough — the spread already extracts elementsImpact on agent-comms
Most of the 13 zero_one_tuple findings have callers using
return method()(e.g.,RuntimeReference.hiddenatruntime_processes.py:310). Without the Return handler, the operation refused them. Now it can rewrite them.Evidence
7/7 tests pass (6 existing + 1 new
test_return_context_reader_wraps_in_tuple).Generated by Claude Code