Repository navigation
Revert #4778 (row-level decode cache): no gain over #4777's window cache - #4779
Merged
Merged
Conversation
…at moved" This reverts commit 64d0e56.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measured the row-level cache installed: observer child ping median ~5.5% across 6 runs, same as #4777's window-level cache (~5.1%) within noise. The row refinement bought nothing — the remaining ~5% is not decode (both caches handle decode; neither gets under 5%), it's the other per-ping work (SQL scan, consumption/responses reads, sidebar rebuild, IPC). So #4778 was added complexity (per-row LRU + a loosened test) for zero measured gain; reverting to #4777's simpler window cache, same result with less machinery. Getting under 5% needs profiling the non-decode per-ping cost — a separate task.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XbFMSnLEc51gw21bLFFRK1