Repository navigation
Keep annotation help out of editor selection - #20
Merged
trissim merged 1 commit intoNov 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Help text no longer chooses a text editor
6 source lines; 8 focused declaration tests pass (0.06 s).
Annotation documentation was flowing through the same foreign metadata reader as editor capabilities.
Annotated[str, "help", PreparedChoices(...)]declaredstrbefore the prepared catalog, so Toad's shared field registry choseStrEditorinstead of the existing model picker or finite-choice dropdown. Numeric and boolean values could be misclassified in the same way.The shared metadata boundary now treats a help string as documentation with no value-kind declarations. The actual annotated value still contributes its own complete MRO, and declared metadata still supplies capabilities first. No per-widget workaround, duplicate selector, generated catalog family, or import guard.
Evidence
tests/test_declared_views.py: 8 collected, 8 passed, exit 0; checks help text with str/int/bool and prepared editor metadata.P189's Toad UI opening/submission repair remains on Toad #1751; this fixes the shared declaration owner rather than special-casing its consumer.