Skip to content

Keep annotation help out of editor selection - #20

Merged
trissim merged 1 commit into
mainfrom
work/parallel-pi--facb040205094c74aa5d542bb53c3205--formbridge
Nov 13, 2026
Merged

trissim merged 1 commit into
mainfrom
work/parallel-pi--facb040205094c74aa5d542bb53c3205--formbridge

Conversation

@trissim

@trissim trissim commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Help text no longer chooses a text editor

6 source lines; 8 focused declaration tests pass (0.06 s).

Annotation documentation was flowing through the same foreign metadata reader as editor capabilities. Annotated[str, "help", PreparedChoices(...)] declared str before the prepared catalog, so Toad's shared field registry chose StrEditor instead of the existing model picker or finite-choice dropdown. Numeric and boolean values could be misclassified in the same way.

The shared metadata boundary now treats a help string as documentation with no value-kind declarations. The actual annotated value still contributes its own complete MRO, and declared metadata still supplies capabilities first. No per-widget workaround, duplicate selector, generated catalog family, or import guard.

Evidence

  • Traced NewThreadCliCommand -> CatalogTargetField.editor_hints -> PreparedChoices.declares -> FormBridge declarations -> DeclaredViews.showing.
  • Observed Model and Thinking resolving to StrEditor before this fix, despite their catalog declarations being intact.
  • tests/test_declared_views.py: 8 collected, 8 passed, exit 0; checks help text with str/int/bool and prepared editor metadata.
  • NRA insert/patch operations authored both source and checks.

P189's Toad UI opening/submission repair remains on Toad #1751; this fixes the shared declaration owner rather than special-casing its consumer.

Copilot AI balanced review requested due to automatic review settings November 13, 2026 01:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim merged commit c1f3cb0 into main Nov 13, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants