Repository navigation
Conversation
source_schema.py imported it from interfaces.py where it doesn't exist. The real declaration is in parser_metaprogramming.py. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dSF2WY8h81JeVyNYgb
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
The validate job imports the entire openhcs runtime through gallery_catalog.py → ExecutionConnectionSpec, but only installed 4 local submodule packages (metaclass-registry, polystore, python-introspect, zmqruntime). This crashed with ModuleNotFoundError: No module named 'pandas' because openhcs declares pandas, numba, scipy etc. in pyproject.toml but nobody ran pip install on openhcs itself. Add `pip install -e .` after the local package installs so the full dependency tree is available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dSF2WY8h81JeVyNYgb
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two fixes for the validate CI job:
source_schema.py: importedFilenameParseResultfrominterfaces.pywhere it doesn't exist — real declaration is inparser_metaprogramming.py. Another wrong import path hidden by the cascade of cycle crashes.website-pages.yml: addedpip install -e .after the local submodule installs. The validate job imports the entire openhcs runtime throughgallery_catalog.py → ExecutionConnectionSpec, but only installed 4 local packages (metaclass-registry, polystore, python-introspect, zmqruntime). This crashed withModuleNotFoundError: No module named 'pandas'because openhcs declares pandas/numba/scipy in pyproject.toml but nobody installed openhcs itself.Handoff notes for whoever takes over
This PR is the tail end of a long cascade of hidden bugs unmasked by the import cycle fixes in PRs #1348–#1351 (all merged to main). Here's the state of play:
Done (on main)
core/payload/plane_provenance.py— the arraypipe extraction's abstract base types replacing concrete domain types in infrastructure signaturescore/(verified by AST scanner inscratchpad/find_cycles.py)slots=Trueremoved from dataclasses with forward-ref annotations (Python 3.12get_type_hints()incompatibility)@dataclassdecorators on enums,@lru_cachefunctions, and plain functions — all removedVariableAxisChoices,GroupingChoices,AxisChoices, 8Lazy*types inAbstractStep) — all removedThis PR
FilenameParseResultimport pathpip install -e .to the validate workflowWhat might still break after this lands
The
pip install -e .should fix the missing-dependency errors (pandas, numba, scipy — all declared in pyproject.toml). But once those imports succeed,gallery_catalog.pywill exercise deeper parts of the runtime. The pattern so far has been: every cycle fix reveals the next crash deeper in the import chain. If that happens:Structural debt remaining
authoring.session.*cluster — outside the validate chain, but structural debtscratchpad/has useful tools:find_cycles.py(AST-based cycle scanner),fix_slots.py(automated slots=True remover),arraypipe-extraction-plan.md,arraypipe-modules.mdThe validate CI error before this fix
That error was from the previous run before the
pip install -e .fix. The root cause was that without openhcs installed, Python couldn't resolve the full dependency tree, so imports failed at arbitrary points.🤖 Generated with Claude Code
https://claude.ai/code/session_01RnH6dSF2WY8h81JeVyNYgb