Repository navigation
Fix aggregate label materialization for separate viewer layers - #523
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic source-bound label TIFFs requested as separate viewer layers previously arrived without the scalar CHANNEL/SITE identity required by the strict route constructor. Reuse the existing typed plane projector to emit exact scalar items with borrowed pixel views while preserving the aggregate TIFF, source order, calibration and STACK display.
The existing stream metadata and backend-kwargs owners derive this behavior from the configured display axes. No component/function-specific projection, receiver default, forced STACK mode or second slicing algorithm is introduced. Single-output kwargs refuse a projection that must change pixels; batch saving carries the actual projected contents and identities.
Synced with main eea91cc (#524 point-ROI fixes and #525 documentation). Final head 1419c5b has byte-identical production source, tests and build configuration to the tested cab5363 checkpoint; the subsequent main merge changed two documentation files only. Validation at cab5363: 447 tests passed with no deselections, covering the 16 public synthetic automatic TIFF/wire cases, all four point-ROI/streaming suites, selected-plane and retained-stack projection, materialization and malformed-domain controls. The initial test invocation failed during collection because the temporary checkout lacked the built native extension. The passing rerun reused the existing environment and native binaries after verifying both C++ sources were byte-identical; no import fallback or test waiver was added. git diff --check passed.
The real renderer, TIFF writer, wire builder and original strict route constructor execute; only final viewer delivery is intercepted. The installed GUI/public journey remains an outstanding parent-owned integration check. No runtime speedup or installed acceptance is claimed.
Closes #515