Repository navigation
A style's missing action is NoStyleAction; right-clicks are the action's own - #245
Merged
Merged
Conversation
…n's own #244 left HandlerArguments.action as `StyleAction | None`, so _activation tested `handler.action is not None` and every consumer of a decoded action had to ask again. - NoStyleAction is the member for meta that names no action: its run returns False, and it offers no activation target, so `activations()` replaces the None test in _activation. - StyleAction.secondary(app, namespace, event) is a right-click on the drawn text; the default answers False. MarkdownLink asks its widget (OpensMarkdownLinks.link_menu), so an app adds a link menu by overriding one method instead of re-decoding the action by type. - run returns whether there was an action to run, which HandlerArguments.run passes on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 commit. This follows #244, whose
StyleAction | Nonewas IMPL-9:Nonebranched on (_activation.py:43'shandler.action is not None), and right-click handling had to re-decode the action by type. Toad's NRA gate caught both on its companion PR.NoStyleAction: the member for meta that names no action.runreturns False andactivations()offers no target, so theNonetest is gone.StyleAction.secondary(app, namespace, event): a right-click on the drawn text, False by default.MarkdownLinkasks its widget throughOpensMarkdownLinks.link_menu.runreturns whether there was an action.Proof: key, binding, markdown, links, text area, option list, tree and data table tests: 655 passed. The 3
test_editor_statereds fail identically on clean main.🤖 Generated with Claude Code