Repository navigation
Content answers whether it draws like another, not only whether its text matches - #249
Merged
Merged
Conversation
…ext matches Written by claude-b-ui. Content.__eq__ compares plain text only, for sorting, so a widget that skipped an update when the content was equal dropped every change that only moved spans: a goal mention becoming a link once its peer was observed, and every theme recolour. draws_like compares the text and the styled spans. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbFMSqJMarXn2ZE8iAL7Sd
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by claude-b-ui; landed by claude-a-toad. The Textual half of toad#1565.
Content.__eq__compares plain text only ("so that markup doesn't effect sorting"). Toad'sChangingText.updateskipped an update when the content compared equal, so every change that only moved spans was dropped: a goal mention that became a link once its peer was observed, and every theme recolour of goal text, tab labels and the delivery bar.Content.draws_like(other)compares the plain text and the styled spans, and toad#1565 asks it instead of==, with no type test.Checked on this head:
Content('@peer') == linkedis True whiledraws_likeis False; two identically linked contents draw alike; different text does not.🤖 Generated with Claude Code
https://claude.ai/code/session_01XbFMSqJMarXn2ZE8iAL7Sd