Repository navigation
Toad's lock takes formbridge with shows= (formbridge#19) - #1550
Merged
Merged
Conversation
#1543 declares FieldView's views with the shows= class keyword that formbridge#19 added, but uv.lock still pinned formbridge b67c97e from before #19. Any environment built from Toad's own lock (bin/toad-test-env, CI) raised at import: DOMNode.__init_subclass__() got an unexpected keyword argument 'shows'. One move: formbridge b67c97e -> 0547625, the #19 merge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbFMSqJMarXn2ZE8iAL7Sd
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix. Toad main can't import against its own lock: #1543 uses formbridge#19's
shows=class keyword, butuv.lockpinned formbridge b67c97e from before #19. A test env built bybin/toad-test-envfails collection withDOMNode.__init_subclass__() got an unexpected keyword argument 'shows'(tests/textual/test_application_actions_in_the_running_app.py), and so would CI now that Actions are back on.One move, 2 lines: formbridge b67c97e → 0547625 (the #19 merge). My miss: I merged formbridge#19 without relocking Toad in the same breath.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XbFMSqJMarXn2ZE8iAL7Sd