Repository navigation
Share viewed-object configuration through lazy ObjectState inheritance - #1750
Merged
Merged
Conversation
|
debt-src at aeeca92 blocks on 50 lines: Warn-only, never blocks (36) |
trissim
marked this pull request as ready for review
November 12, 2026 23:09
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P192 — viewed-object properties
Toad PR: #1750
ObjectState PR: OpenHCSDev/ObjectState#66
ObjectState merged: 226fcd8918e16f6d1b594cac0bdcf8057aab832a
The same ObjectConfiguration edits the properties sidebar and context form.
The settings declarations own field scope; ordinary files inherit view settings,
conversations inherit those and their composer/agent display fields. The actual
TabIdentity is saved beside raw explicit overrides. None means inherit; choosing
Override here pins even an equal value, and Use global default resumes inheritance.
The original global ObjectState supplies values and source information. A duplicate
open identity or a forbidden override refuses rather than introducing another answer.
Local display configuration stays local; remote agent and rule writes remain Core's.
ObjectState previously stopped at direct dataclass children. The shared extraction
now traverses each declared stored object once, retains shared instances and refuses
conflicting instances of one nominal configuration type. No parallel resolver.
Closed property sidebars inherit LazyThreadSidebar; the native session sidebar uses
that same lifecycle instead of a copy. Editors paint after native mount. Global and
object field-view families remain separate through their declared family owner.
All contextual action menus carry actual operations; the mirrored string/action
maps and show_target_menu are removed. Link menus keep their original admission.
Evidence:
same-state sidebar/context edits, reset, source, persistence, and scope filtering.
and collision controls.
1 passed, exit 0. Initial launch failed before behavior because the inherited
descriptor limit was 1024 while the existing helper requests descriptors >=1024;
the successful launch used soft limit 8192, below hard limit 524288.
The source check is exactly class ObjectConfiguration(, not the dialog's name.
The original order's created-owner citation named the new file's first line; the
actual state class is in object_configuration.py. The eliminated file-menu identity
copy is now owned by the selected ActionMenu row, not by a second callable map.
No paid provider command or profile was run. No install or physical desktop trial
is claimed by this source report. Auth recovery is independently held by codex-parallel.