Repository navigation
fix: read setting leaves and use the existing viewed-object bar - #1752
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SettingsReader now reads ObjectState.fields. FieldProxy follows the existing ParameterStructure, resolving one leaf rather than reconstructing every dataclass during paint. ObjectState #67 merged as d34d75803d3b7e65128bf43ab867bb70f37cd013 and this package declares that version.
Properties are a panel in the existing ThreadSidebar. Session, channel and file views inherit the same bar resource; the separate ObjectSidebar and mounting marker are deleted. The right-click editor and that panel still edit the same ObjectConfiguration. Lazy inheritance, explicit overrides, reset and persistence remain owned there.
The user's existing settings actually contain an object sidebar placement. Its value declaration is retained solely to decode that saved data; a nominal ActiveSidebarPlacement parent derives the two current roles, so the old role cannot claim screen space. No configuration file was written.
Executed small native controls: real Toad settings follow registered global edits, retain an explicit child override, and inherit again on reset; padding resolves as a leaf. All three view classes import and are concrete. A first inheritance attempt omitted the application's registry registration and failed setup; corrected application lifecycle passed. A later control reached every assertion for active roles, inherited bar methods and current saved-layout decoding, printed its result, then exceeded the 15-second outer limit during process exit (exit 124). This is not a passing process-exit check. No suite, profile or CPU-speed claim. Physical sidebar trial and live CPU effect follow installation.