Repository navigation
Discover viewed-object settings in the existing sidebar - #1753
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-src at 63e1a45 blocks on 17 lines: Warn-only, never blocks (2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The viewed-object bar now has one dropdown. Its settings entries come from that view's admitted dataclass fields; native agent panels join those entries through their existing declared family. No settings roster or third bar is added. The context menu opens the same entries over the same ObjectState.
OpenHCS's ConfigWindow binds each selected config to its original ObjectState and builds its editor lazily. This change follows that ownership: one retained view state inherits the live global defaults, and only the selected form is built. Explicit overrides, reset, persistence and field-source metadata stay with ObjectConfiguration and DeclaredField.
Channel views no longer create Connection/Comms agent panels using the sender's identity. File, channel and native views inherit the same sidebar resource and selection lifecycle. Settings entries retain their actual DottedFieldPath identity, rather than matching display labels. Native role panels retain their nominal widget identity.
Accordion-specific relationship, context, project and plan readers now use an inherited panel-host capability. A dropdown page and a collapsible both own their visibility and reveal behavior. Hidden dropdown pages stop asking for observations. Plan arrival can select its original panel; keyboard focus goes to the view's own control.
One focused actual UI control passed in 14.63s: channel and file selection, declaration discovery, lazy forms, nonempty painted fields, dropdown switching, live default inheritance, explicit override/reset, return-to-view retention, shared context editor state, native relationship-panel activation and hidden-panel visibility. Earlier attempts exposed the shell descriptor limit and a redundant abstract override hiding the inherited sidebar factory; both were corrected. No paid provider, broad suite or profiler was used. The final keyboard focus change was source-traced; no extra run added. Physical reopened Toad trial remains Tristan's.