Repository navigation
Keep New Thread controls reachable below its scrolling form - #1762
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
November 13, 2026 05:13
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P210: fixed footer, bounded form scroll
The original form case passes at 80×24: 1 passed in 15.19 s. The lower declared selector scrolls into view and opens through a real click; Apply remains reachable before and after scrolling; the first mouse confirmation still submits.
Layout
CommandButtonsinherits the existingDockedBottomcapability. The emptyCommandFormScroll(FillHeight, VerticalScroll)composition uses the space above that footer. The existing confirmation checkbox moves inside the scrolling content. Original fields, selectors and command submission remain; no field-height arithmetic or alternate renderer.Evidence and limits
One original UI case ran at low priority with xdist disabled. Final log:
/home/ts/.cache/agent-scratch/parallel-pi/p210-layout-check-behavior.log.Earlier red runs are retained: I initially used a nonexistent
visible_regionproperty, then assumed a Service Tier field existed, then checked the Select parent's hit identity even though its child receives the click. The final test requires the actual dropdown to open, rather than accepting that misleading parent-hit boolean. These fixture errors are not claimed as product failures or hidden.The separate missing Service Tier control is an absent Core declaration: NewThreadCliCommand, NativeThreadDefaults and NewThreadSpec have Model/Thinking but no Service Tier. Codex-live owns that Core repair. This PR checks the actual lowest declared field and does not pretend to add Service Tier.
Native authored plans and complete logs are retained under
/home/ts/.cache/agent-scratch/parallel-pi/p210-*. No broad scan, provider call, new worktree, profiler or standalone installer. Ready for the shared install batch; installed physical confirmation remains separate from this source/UI evidence.