Repository navigation
Restore original thread panels and lazy inherited settings editing - #1764
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-src at 5929421 failed without a verdict line; the last lines of its stderr: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the original viewed-object bar (P219)
Focused result
P219 source checkpoint
Original viewed-object consumer passed 1/1 in 13.50s, exit 0:
/home/ts/.cache/agent-scratch/codex-latency/viewed-object-repair/consumer-4.log
It checks lazy inherited placeholder text, typing the same inherited value as an explicit override, upstream changes preserving the override, Reset returning to raw None and the current inherited preview, global-field saves, separate channel/file identities, shared context editor state, actual changing ACP advertisements, every original native SessionPanel member, a real rule-gate form and its original backend write, DM peer birth versus actor identity, and hidden-panel observation lifecycle.
Applied owners
Red history retained
consumer.log: helper could not move fds above the shell's 1024 limit; no UI proof.
consumer-2.log: preview style used an invalid empty flag; newly declared peer then missed by a registry read after the app observer started. Store failure reported to claude-laptop as message b65fcca1edb0. The peer fixture is now declared before opening the app.
consumer-3.log: numeric native constraints were incorrectly applied to editor text; rule-gate write refused. Fixed at the shared encoded-editor boundary, preserving original command decoding/validation.
consumer-4.log: passed.
Cold Toad/Core import and MRO passed; original panel family lists all five members and its two shared thread-details members. Native plans and apply logs retained. Existing unrelated guarded annotations remain unchanged; the touched lazy CommandDialog import was promoted to a module import with cold import proof.
No installed or physical-success claim at this checkpoint. No total CPU claim. No subagent, profiling, broad suite or provider request.
Installed and physically viewed
P219 installed result
Core #4687 merged as f71b89f99f28f38f3688e2524c050952e6842a4a.
Toad #1764 merged as 27b54aa.
Installed together in core-f71b89f99-lock-afe2a6d8e0a009a8. Exact installed source matches the tested editor, reset, command form, panel menu, peer sidebar, configuration declaration and command writers. Fresh bus delivery was answered by parallel-pi as 15047-9052131f682d, answering 15046-18a6faa348b4.
Original view-menu consumer: 1 passed in 13.50s, exit0. consumer-4.log contains the result; previous reds remain alongside it. The source/consumer report is .verification/viewed-object-repair/delivery.md in the Toad checkout.
Physical check
Successful actual installed Toad run: physical-v4/ in this evidence directory. Plain st on its own Xvfb display, copied bus, private frontend home/config/state/data. The controller selected the existing gutter with a real mouse click, opened the original panel dropdown, selected User interface settings, and clicked the original Reset control.
Viewed screenshots:
The original UI consumer, not this physical copy, verifies the rule-gate form and actual backend save. CheckRoot intentionally does not copy the live rule deal or read evidence. DM actor/peer separation and channel/file isolation were also exercised by that original consumer.
Physical startup/control errors are preserved: physical.log lacked an explicit source root; physical-2.log exceeded the default framebuffer; physical-3.log incorrectly waited for native-agent readiness in an external CLI mailbox; physical-4.log incorrectly expected Ctrl+B to open the thread bar: ShowSidebarAction at src/toad/view_actions.py:28 explicitly reveals workspace_chrome.channels. The key worked on its declared Channels owner; this was a controller expectation error, not a keyboard product bug. physical-5.log passed using the original mouse gutter path. No product source was changed for those controller errors. Each failed run's owners retired its processes; physical-v4 has final st/Xvfb/journey/private-root retirement records.
No provider prompt was sent. No user desktop or user process was touched. No total CPU improvement claimed; CPU remains with claude-laptop. A later unrelated Core install moved current to 48b957826 with the same Toad lock; this physical proof names its actual f71 runtime.
Core accepted order 2ff7e43a8851 as delivered through order done codex-live P219, exit0. No delegated implementation or subagent was used.