Repository navigation
⚕️♻️:settle who the authorship files name - #1873
Conversation
The entry named someone with no commits in this repository's history. The two `.mailmap` lines went with it: one declared the canonical form of that identity and the other mapped a second spelling onto it, and with nothing in the history under either address they canonicalized nothing. `git log` reports the same set of authors before and after, which is what says those lines were inert rather than load-bearing. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughUpdated contributor identity metadata by removing obsolete mappings and the Princess Irulen entry. ChangesContributor identity cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR only reconciles repository author attribution records, with the reported verification checks passing and no actionable merge-blocking risk remaining. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The mailmap canonicalized on `OpenINF-bot`, a spelling that appears nowhere else: the account is named OpenINF Bot, `AUTHORS` says OpenINF Bot, and seven of the eight commits are authored that way. Only the mailmap disagreed, so every one of them was being rewritten into the one spelling nobody uses. The third line went with it. It mapped the name onto the canonical form, which after the rename is the same string on both sides, and it had never matched a commit anyway -- no commit pairs that name with that address. All eight still resolve, now to one identity rather than to a name invented for the file. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
Two changes to the files that say who has worked on this repository.
Drop an entry with no commits behind it
Derek Lewis <DerekNonGeneric@inf.is> -Princess Irulen <grimes@open.inf.is> OpenINF Bot <openinfbot@open.inf.is>The two
.mailmaplines for that identity came along because they hadnothing left to do: one declared its canonical form and the other
mapped a second spelling onto it, and there are no commits in this
repository under either address. If you would rather keep the mapping
against future commits from that address, say so and I will restore
those two lines — the
AUTHORSchange stands on its own.Name the bot the way it names itself
OpenINF-botwas a spelling the mailmap alone used. The account isnamed OpenINF Bot,
AUTHORSsays OpenINF Bot, and seven of the eightcommits are authored that way — so the mailmap was rewriting all of
them into the one spelling nothing else uses, and
AUTHORSand.mailmapdisagreed with each other. They agree now.The third line went with it. It mapped that name onto the canonical
form, which after the rename is the same string on both sides, and it
had never matched a commit: none pairs that name with that address.
Checked
nps test— all verify tasks pass.git log --format='%aN <%aE>' | sort -u:mailmap lines were inert rather than load-bearing;
OpenINF Bot <openinfbot@open.inf.is>rather than toOpenINF-bot.git grep 'OpenINF-bot'returns nothing; it existed only in.mailmap.Summary by CodeRabbit