Skip to content

test: UdpHeartbeatTest no longer races the sent count (#247) #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
compot-dev merged 1 commit into from
Oct 20, 2026
Merged

test: UdpHeartbeatTest no longer races the sent count (#247) #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion android/app/src/test/java/com/openipc/decoder/UdpHeartbeatTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,10 @@ public void sendsOneOneEverySecondUntilClosed() throws Exception {
// About one interval apart: the scheduler neither bursts nor stalls
long span = at[at.length - 1] - at[0];
assertTrue("span " + span, span >= 3 * 100 - 40 && span < 3 * 100 + 400);
assertTrue(h.sent() >= 4);
// The count goes up after send() returns, maybe after the toy got the packet (#247)
long until = System.nanoTime() / 1_000_000 + 1000;
while (h.sent() < 4 && System.nanoTime() / 1_000_000 < until) Thread.sleep(5);
assertTrue("sent " + h.sent(), h.sent() >= 4);
h.close();
assertFalse(h.running());
// What was on its way is read; then nothing more
Expand Down
Loading