Add Have I Been Pwned password requirements check - #426
Open
mgaffigan wants to merge 2 commits into
Open
Conversation
mgaffigan
requested review from
a team,
NicoPiel,
gibson9583,
jonbartels,
kayyagari,
kpalang,
ssrowe and
tonygermano
August 29, 2026 18:54
mgaffigan
force-pushed
the
feat/hibp-password-verifier
branch
from
August 29, 2026 19:25
1170e49 to
89ce90f
Compare
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
mgaffigan
force-pushed
the
feat/hibp-password-verifier
branch
from
August 29, 2026 19:57
89ce90f to
7385ea7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIST SP 800-63B §5.1.1.2 requires passwords to be checked against leak lists. This fixes that gap in OIE by adding support for checking HIBP's API. Confidentiality of the password is maintained by k-anonymity. The setting is default-enabled on new installations.
Testing can be accomplished by trying to change the password to "correct horse battery staple":
The functionality is default-disabled for upgrades, and can be enabled/disabled by setting/clearing the new
password.breachedurlmirth.properties setting.