Check password requirements on login - #427
Open
mgaffigan wants to merge 2 commits into
Open
Conversation
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
mgaffigan
requested review from
a team,
NicoPiel,
gibson9583,
jonbartels,
kayyagari,
kpalang,
pacmano1 and
ssrowe
August 29, 2026 19:59
NicoPiel
approved these changes
Aug 29, 2026
Contributor
|
What does this do when I try to grab a token to make API calls? If it denies the token, we need to work through that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing password requirements does not affect current users. This PR modifies the login process to check requirements and handle them the same as password expiration, using the existing grace period functionality.
Note:
commanddoes not seem to handle expired passwords well.Note to reviewers: Most of this change-set is whitespace changes due to indentation. See https://github.com/OpenIntegrationEngine/engine/pull/427/changes?w=1