Repository navigation
fix(road-conditions): open a long incident text in place instead of a second scroll area - #690
Merged
Merged
Conversation
… second scroll area
Medformatik
enabled auto-merge (squash)
October 30, 2026 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Follow-up to #678. A long source text in the incident card scrolled inside the card, so the popup had two scroll areas. In a stack of conditions, the card scrolled inside the popup's own scroll.
Now the card has no inner scroll area:
The toggle is a native
<details>, so it works by keyboard and needs no script in the HTML-string popup. The full text is always in the card; the toggle only removes the fade and height limit.Long source text (A42 congestion, NDW)
Each image shows the card closed on the left and opened on the right.
These images are the branch's card HTML with the branch
globals.cssin a standalone page, not the live map. The text is the A42 report from the review screenshot. Mobile viewports were not captured.Verification
vitest --project node: 1,362 files, 18,495 tests passed.vitest --project web: 590 files, 5,604 passed.tsc --noEmit -p tsconfig.integrations.json: clean. Biome on changed files: no errors.check-translations: no errors.Release and upgrade impact
Product impact: ordinary