Skip to content

Remove all references to spurious "complex non-absolute min/max" functions #6129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin-frbg merged 5 commits into from
Oct 15, 2026
Merged

Remove all references to spurious "complex non-absolute min/max" functions #6129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1963a66
Remove spurious "indexed non-absolute complex min/max" functions
martin-frbg Oct 14, 2026
4d7b245
Remove spurious "complex non-absolute indexed min/max" functions
martin-frbg Oct 14, 2026
0a4f054
Remove spurious "complex non-absolute indexed min/max" functions
martin-frbg Oct 14, 2026
2406847
Remove spurious "complex non-absolute min/max" functions
martin-frbg Oct 14, 2026
c16031f
Properly wrap the S and D MIN/MAX entries in BUILD conditionals now t…
martin-frbg Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions cblas.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,13 +181,8 @@ OPENBLAS_EXPORT double cblas_dzamin(OPENBLAS_CONST blasint n, OPENBLAS_CONST voi

OPENBLAS_EXPORT CBLAS_INDEX cblas_ismax(OPENBLAS_CONST blasint n, OPENBLAS_CONST float *x, OPENBLAS_CONST blasint incx);
OPENBLAS_EXPORT CBLAS_INDEX cblas_idmax(OPENBLAS_CONST blasint n, OPENBLAS_CONST double *x, OPENBLAS_CONST blasint incx);
OPENBLAS_EXPORT CBLAS_INDEX cblas_icmax(OPENBLAS_CONST blasint n, OPENBLAS_CONST void *x, OPENBLAS_CONST blasint incx);
OPENBLAS_EXPORT CBLAS_INDEX cblas_izmax(OPENBLAS_CONST blasint n, OPENBLAS_CONST void *x, OPENBLAS_CONST blasint incx);

OPENBLAS_EXPORT CBLAS_INDEX cblas_ismin(OPENBLAS_CONST blasint n, OPENBLAS_CONST float *x, OPENBLAS_CONST blasint incx);
OPENBLAS_EXPORT CBLAS_INDEX cblas_idmin(OPENBLAS_CONST blasint n, OPENBLAS_CONST double *x, OPENBLAS_CONST blasint incx);
OPENBLAS_EXPORT CBLAS_INDEX cblas_icmin(OPENBLAS_CONST blasint n, OPENBLAS_CONST void *x, OPENBLAS_CONST blasint incx);
OPENBLAS_EXPORT CBLAS_INDEX cblas_izmin(OPENBLAS_CONST blasint n, OPENBLAS_CONST void *x, OPENBLAS_CONST blasint incx);

OPENBLAS_EXPORT void cblas_saxpy(OPENBLAS_CONST blasint n, OPENBLAS_CONST float alpha, OPENBLAS_CONST float *x, OPENBLAS_CONST blasint incx, float *y, OPENBLAS_CONST blasint incy);
OPENBLAS_EXPORT void cblas_daxpy(OPENBLAS_CONST blasint n, OPENBLAS_CONST double alpha, OPENBLAS_CONST double *x, OPENBLAS_CONST blasint incx, double *y, OPENBLAS_CONST blasint incy);
Expand Down
8 changes: 0 additions & 8 deletions common_c.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,8 @@

#define CAMAX_K camax_k
#define CAMIN_K camin_k
#define CMAX_K cmax_k
#define CMIN_K cmin_k
#define ICAMAX_K icamax_k
#define ICAMIN_K icamin_k
#define ICMAX_K icmax_k
#define ICMIN_K icmin_k
#define CASUM_K casum_k
#define CAXPYU_K caxpy_k
#define CAXPYC_K caxpyc_k
Expand Down Expand Up @@ -292,12 +288,8 @@

#define CAMAX_K gotoblas -> camax_k
#define CAMIN_K gotoblas -> camin_k
#define CMAX_K gotoblas -> cmax_k
#define CMIN_K gotoblas -> cmin_k
#define ICAMAX_K gotoblas -> icamax_k
#define ICAMIN_K gotoblas -> icamin_k
#define ICMAX_K gotoblas -> icmax_k
#define ICMIN_K gotoblas -> icmin_k
#define CASUM_K gotoblas -> casum_k
#define CAXPYU_K gotoblas -> caxpy_k
#define CAXPYC_K gotoblas -> caxpyc_k
Expand Down
4 changes: 0 additions & 4 deletions common_interface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,6 @@ blasint OPENBLAS_API(ixamax)(blasint *, xdouble *, blasint *);
blasint OPENBLAS_API(ismax) (blasint *, float *, blasint *);
blasint OPENBLAS_API(idmax) (blasint *, double *, blasint *);
blasint OPENBLAS_API(iqmax) (blasint *, xdouble *, blasint *);
blasint OPENBLAS_API(icmax) (blasint *, float *, blasint *);
blasint OPENBLAS_API(izmax) (blasint *, double *, blasint *);
blasint OPENBLAS_API(ixmax) (blasint *, xdouble *, blasint *);

blasint OPENBLAS_API(isamin)(blasint *, float *, blasint *);
Expand All @@ -165,8 +163,6 @@ blasint OPENBLAS_API(ixamin)(blasint *, xdouble *, blasint *);
blasint OPENBLAS_API(ismin)(blasint *, float *, blasint *);
blasint OPENBLAS_API(idmin)(blasint *, double *, blasint *);
blasint OPENBLAS_API(iqmin)(blasint *, xdouble *, blasint *);
blasint OPENBLAS_API(icmin)(blasint *, float *, blasint *);
blasint OPENBLAS_API(izmin)(blasint *, double *, blasint *);
blasint OPENBLAS_API(ixmin)(blasint *, xdouble *, blasint *);

FLOATRET OPENBLAS_API(samax) (blasint *, float *, blasint *);
Expand Down
8 changes: 0 additions & 8 deletions common_macro.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1917,12 +1917,8 @@

#define AMAX_K ZAMAX_K
#define AMIN_K ZAMIN_K
#define MAX_K ZMAX_K
#define MIN_K ZMIN_K
#define IAMAX_K IZAMAX_K
#define IAMIN_K IZAMIN_K
#define IMAX_K IZMAX_K
#define IMIN_K IZMIN_K
#define ASUM_K ZASUM_K
#define AXPYU_K ZAXPYU_K
#define AXPYC_K ZAXPYC_K
Expand Down Expand Up @@ -2437,12 +2433,8 @@

#define AMAX_K CAMAX_K
#define AMIN_K CAMIN_K
#define MAX_K CMAX_K
#define MIN_K CMIN_K
#define IAMAX_K ICAMAX_K
#define IAMIN_K ICAMIN_K
#define IMAX_K ICMAX_K
#define IMIN_K ICMIN_K
#define ASUM_K CASUM_K
#define AXPYU_K CAXPYU_K
#define AXPYC_K CAXPYC_K
Expand Down
8 changes: 0 additions & 8 deletions common_z.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,8 @@

#define ZAMAX_K zamax_k
#define ZAMIN_K zamin_k
#define ZMAX_K zmax_k
#define ZMIN_K zmin_k
#define IZAMAX_K izamax_k
#define IZAMIN_K izamin_k
#define IZMAX_K izmax_k
#define IZMIN_K izmin_k
#define ZASUM_K zasum_k
#define ZAXPYU_K zaxpy_k
#define ZAXPYC_K zaxpyc_k
Expand Down Expand Up @@ -292,12 +288,8 @@

#define ZAMAX_K gotoblas -> zamax_k
#define ZAMIN_K gotoblas -> zamin_k
#define ZMAX_K gotoblas -> zmax_k
#define ZMIN_K gotoblas -> zmin_k
#define IZAMAX_K gotoblas -> izamax_k
#define IZAMIN_K gotoblas -> izamin_k
#define IZMAX_K gotoblas -> izmax_k
#define IZMIN_K gotoblas -> izmin_k
#define ZASUM_K gotoblas -> zasum_k
#define ZAXPYU_K gotoblas -> zaxpy_k
#define ZAXPYC_K gotoblas -> zaxpyc_k
Expand Down
4 changes: 2 additions & 2 deletions exports/gensymbol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ cblasobjsc="
cblas_csscal cblas_cswap cblas_csymm cblas_csyr2k cblas_csyrk cblas_ctbmv cblas_cgeadd
cblas_ctbsv cblas_ctpmv cblas_ctpsv cblas_ctrmm cblas_ctrmv cblas_ctrsm cblas_ctrsv
cblas_scnrm2 cblas_scasum cblas_cgemmt cblas_cgemmtr
cblas_icamax cblas_icamin cblas_icmin cblas_icmax cblas_scsum cblas_cimatcopy cblas_comatcopy
cblas_icamax cblas_icamin cblas_scsum cblas_cimatcopy cblas_comatcopy
cblas_caxpyc cblas_crotg cblas_csrot cblas_scamax cblas_scamin cblas_cgemm_batch cblas_cgemm_batch_strided
"
cblasobjsd="
Expand Down Expand Up @@ -126,7 +126,7 @@ cblasobjsz="
cblas_ztbmv cblas_ztbsv cblas_ztpmv cblas_ztpsv cblas_ztrmm cblas_ztrmv cblas_ztrsm
cblas_ztrsv cblas_cdotc_sub cblas_cdotu_sub cblas_zdotc_sub cblas_zdotu_sub
cblas_zaxpby cblas_zgeadd cblas_zgemmt cblas_zgemmtr
cblas_izamax cblas_izamin cblas_izmin cblas_izmax cblas_dzsum cblas_zimatcopy cblas_zomatcopy
cblas_izamax cblas_izamin cblas_dzsum cblas_zimatcopy cblas_zomatcopy
cblas_zaxpyc cblas_zdrot cblas_zrotg cblas_dzamax cblas_dzamin cblas_zgemm_batch cblas_zgemm_batch_strided
"

Expand Down
4 changes: 2 additions & 2 deletions exports/gensymbol.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
cblas_csscal, cblas_cswap, cblas_csymm, cblas_csyr2k, cblas_csyrk, cblas_ctbmv, cblas_cgeadd,
cblas_ctbsv, cblas_ctpmv, cblas_ctpsv, cblas_ctrmm, cblas_ctrmv, cblas_ctrsm, cblas_ctrsv,
cblas_scnrm2, cblas_scasum, cblas_cgemmt, cblas_cgemmtr,
cblas_icamax, cblas_icamin, cblas_icmin, cblas_icmax, cblas_scsum,cblas_cimatcopy,cblas_comatcopy,
cblas_icamax, cblas_icamin, cblas_scsum,cblas_cimatcopy,cblas_comatcopy,
cblas_caxpyc, cblas_crotg, cblas_csrot, cblas_scamax, cblas_scamin, cblas_cgemm_batch, cblas_cgemm_batch_strided);

@cblasobjsd = (
Expand Down Expand Up @@ -123,7 +123,7 @@
cblas_ztbmv, cblas_ztbsv, cblas_ztpmv, cblas_ztpsv, cblas_ztrmm, cblas_ztrmv, cblas_ztrsm,
cblas_ztrsv, cblas_cdotc_sub, cblas_cdotu_sub, cblas_zdotc_sub, cblas_zdotu_sub,
cblas_zaxpby, cblas_zgeadd, cblas_zgemmt, cblas_zgemmtr,
cblas_izamax, cblas_izamin, cblas_izmin, cblas_izmax, cblas_dzsum,cblas_zimatcopy,cblas_zomatcopy,
cblas_izamax, cblas_izamin, cblas_dzsum,cblas_zimatcopy,cblas_zomatcopy,
cblas_zaxpyc, cblas_zdrot, cblas_zrotg, cblas_dzamax, cblas_dzamin, cblas_zgemm_batch, cblas_zgemm_batch_strided);

@cblasobjs = ( cblas_xerbla );
Expand Down
30 changes: 25 additions & 5 deletions interface/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,16 +137,36 @@ endif ()
# gemmtr is gemmt under the name adopted by the Reference BLAS
GenerateNamedObjects("gemmt.c" "RNAME" "gemmtr" ${CBLAS_FLAG})

# max and imax are compiled 4 times
GenerateNamedObjects("max.c" "" "" ${CBLAS_FLAG})
# absolute max and imax are compiled 4 times but non-absolute does not exist for complex
if (BUILD_SINGLE)
GenerateNamedObjects("max.c" "" "smax" ${CBLAS_FLAG} "" "" true "SINGLE")
endif()
if (BUILD_DOUBLE)
GenerateNamedObjects("max.c" "" "dmax" ${CBLAS_FLAG} "" "" true "DOUBLE")
endif()
GenerateNamedObjects("max.c" "USE_ABS" "amax" ${CBLAS_FLAG})
GenerateNamedObjects("max.c" "USE_ABS;USE_MIN" "amin" ${CBLAS_FLAG})
GenerateNamedObjects("max.c" "USE_MIN" "min" ${CBLAS_FLAG})
if (BUILD_SINGLE)
GenerateNamedObjects("max.c" "USE_MIN" "smin" ${CBLAS_FLAG} "" "" true "SINGLE")
endif()
if (BUILD_DOUBLE)
GenerateNamedObjects("max.c" "USE_MIN" "dmin" ${CBLAS_FLAG} "" "" true "DOUBLE")
endif()

GenerateNamedObjects("imax.c" "" "i*max" ${CBLAS_FLAG})
if (BUILD_SINGLE)
GenerateNamedObjects("imax.c" "" "ismax" ${CBLAS_FLAG} "" "" true "SINGLE")
endif()
if (BUILD_DOUBLE)
GenerateNamedObjects("imax.c" "" "idmax" ${CBLAS_FLAG} "" "" true "DOUBLE")
endif()
GenerateNamedObjects("imax.c" "USE_ABS" "i*amax" ${CBLAS_FLAG})
GenerateNamedObjects("imax.c" "USE_ABS;USE_MIN" "i*amin" ${CBLAS_FLAG})
GenerateNamedObjects("imax.c" "USE_MIN" "i*min" ${CBLAS_FLAG})
if (BUILD_SINGLE)
GenerateNamedObjects("imax.c" "USE_MIN" "ismin" ${CBLAS_FLAG} "" "" true "SINGLE")
endif()
if (BUILD_DOUBLE)
GenerateNamedObjects("imax.c" "USE_MIN" "idmin" ${CBLAS_FLAG} "" "" true "DOUBLE")
endif()

if (BUILD_BFLOAT16)
GenerateNamedObjects("scal.c" "BGEMM" "bscal" ${CBLAS_FLAG} "" "" true "BFLOAT16")
Expand Down
16 changes: 2 additions & 14 deletions interface/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ CCBLAS1OBJS = \
cblas_cscal.$(SUFFIX) cblas_csscal.$(SUFFIX) \
cblas_cswap.$(SUFFIX) cblas_scnrm2.$(SUFFIX) \
cblas_caxpby.$(SUFFIX) cblas_scamax.$(SUFFIX) cblas_caxpyc.$(SUFFIX) cblas_scamin.$(SUFFIX) \
cblas_icmin.$(SUFFIX) cblas_icmax.$(SUFFIX) cblas_scsum.$(SUFFIX) cblas_csrot.$(SUFFIX) cblas_crotg.$(SUFFIX)
cblas_scsum.$(SUFFIX) cblas_csrot.$(SUFFIX) cblas_crotg.$(SUFFIX)

CCBLAS2OBJS = \
cblas_cgemv.$(SUFFIX) cblas_cgerc.$(SUFFIX) cblas_cgeru.$(SUFFIX) \
Expand Down Expand Up @@ -399,7 +399,7 @@ CZBLAS1OBJS = \
cblas_zscal.$(SUFFIX) cblas_zdscal.$(SUFFIX) \
cblas_zswap.$(SUFFIX) cblas_dznrm2.$(SUFFIX) \
cblas_zaxpby.$(SUFFIX) cblas_zaxpyc.$(SUFFIX) \
cblas_izmin.$(SUFFIX) cblas_izmax.$(SUFFIX) cblas_dzsum.$(SUFFIX) cblas_zdrot.$(SUFFIX) cblas_zrotg.$(SUFFIX)
cblas_dzsum.$(SUFFIX) cblas_zdrot.$(SUFFIX) cblas_zrotg.$(SUFFIX)


CZBLAS2OBJS = \
Expand Down Expand Up @@ -1611,18 +1611,6 @@ cblas_ismin.$(SUFFIX) cblas_ismin.$(PSUFFIX) : imax.c
cblas_idmin.$(SUFFIX) cblas_idmin.$(PSUFFIX) : imax.c
$(CC) $(CFLAGS) -DCBLAS -c -UUSE_ABS -DUSE_MIN $< -o $(@F)

cblas_icmax.$(SUFFIX) cblas_icmax.$(PSUFFIX) : imax.c
$(CC) $(CFLAGS) -DCBLAS -c -UUSE_ABS -UUSE_MIN $< -o $(@F)

cblas_izmax.$(SUFFIX) cblas_izmax.$(PSUFFIX) : imax.c
$(CC) $(CFLAGS) -DCBLAS -c -UUSE_ABS -UUSE_MIN $< -o $(@F)

cblas_icmin.$(SUFFIX) cblas_icmin.$(PSUFFIX) : imax.c
$(CC) $(CFLAGS) -DCBLAS -c -UUSE_ABS -DUSE_MIN $< -o $(@F)

cblas_izmin.$(SUFFIX) cblas_izmin.$(PSUFFIX) : imax.c
$(CC) $(CFLAGS) -DCBLAS -c -UUSE_ABS -DUSE_MIN $< -o $(@F)

cblas_samax.$(SUFFIX) cblas_samax.$(PSUFFIX) : max.c
$(CC) $(CFLAGS) -DCBLAS -c -DUSE_ABS -UUSE_MIN $< -o $(@F)

Expand Down
Loading