fuzz_ppd: Fix memory leaks on early return paths - #59
Open
princemittalr wants to merge 1 commit into
Open
Conversation
All strdup'd variables (ppdsize, legacy, pwg, ppdmedia, marked_option, options_str) and dynamically allocated cups_options/cups_values arrays were not freed when execution terminated early via return 1. Refactored fuzz_ppd() to initialize all pointers to NULL at declaration and use goto cleanup pattern so all allocations are freed on every exit path. Fixes: OpenPrinting#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
All strdup'd variables (ppdsize, legacy, pwg, ppdmedia, marked_option,
options_str) and dynamically allocated cups_options/cups_values arrays
were not freed when execution terminated early via return 1.
Refactored fuzz_ppd() to:
allocations regardless of which exit path was taken
This ensures OSS-Fuzz can focus on real bugs rather than false
positives from harness memory leaks.