mid_registrar: persist TCP connections for absorbed REGISTERs - #4245
Open
greenbea wants to merge 1 commit into
Open
mid_registrar: persist TCP connections for absorbed REGISTERs#4245greenbea wants to merge 1 commit into
greenbea wants to merge 1 commit into
Conversation
When `tcp_persistent_flag` is enabled, TCP connection lifetime is updated only after a forwarded REGISTER receives a successful response. Absorbed REGISTERs return a local 200 OK without extending the receiving connection, leaving new or refreshed connections at the default lifetime. Apply the UAC Contact expiration to the TCP connection in the `quick_reply` path, matching the existing behavior for forwarded registrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
tcp_persistent_flagis enabled, TCP connection lifetime is updated only after a forwarded REGISTER receives a successful response.Absorbed REGISTERs return a local 200 OK without extending the receiving connection, leaving new or refreshed connections at the default lifetime.
Details
Solution
Apply the UAC Contact expiration to the TCP connection in the
quick_replypath, matching the existing behavior for forwarded registrations.Compatibility
Closing issues