proto_ws: handle CRLF keep-alives in WS messages - #4246
Open
greenbea wants to merge 1 commit into
Open
Conversation
Browser WebSocket APIs cannot send native WebSocket Ping frames, so browser-based SIP clients use the RFC 5626 CRLF keep-alive mechanism, as permitted by RFC 7118. Recognize double-CRLF pings and single-CRLF pongs carried in WebSocket data frames. Reply with a single-CRLF text frame and prevent these keep-alives from reaching the SIP parser. This applies to both WS and WSS transports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browser WebSocket APIs cannot send native WebSocket Ping frames, so browser-based SIP clients use the RFC 5626 CRLF keep-alive mechanism, as permitted by RFC 7118.
Details
Solution
Recognize double-CRLF pings and single-CRLF pongs carried in WebSocket data frames. Reply with a single-CRLF text frame and prevent these keep-alives from reaching the SIP parser.
This applies to both WS and WSS transports.
Compatibility
Closing issues