Skip to content

chore: remove welcome screen and onboarding tour - #261

Merged
hhvrc merged 3 commits into
developfrom
chore/remove-welcome-screen
Oct 28, 2026
Merged

hhvrc merged 3 commits into
developfrom
chore/remove-welcome-screen

Conversation

@hhvrc

@hhvrc hhvrc commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

The welcome screen passed its sunset date, and the tour could only be started from it. Removes the welcome screen, the driver.js tour and its data-tour anchors, the PUBLIC_DISABLE_ONBOARDING flag and the driver.js dependency.

Summary by CodeRabbit

  • Changes
    • The welcome screen and guided onboarding tour are no longer available. Signing in no longer prompts users to start the tour.
    • On app startup, saved welcome and tour data is removed from local storage when accessible. This cleanup targets onboarding data; other saved app data is unaffected.

The welcome screen passed its sunset date, and the tour could only be started from it.
Removes the welcome screen, the driver.js tour and its data-tour anchors, the PUBLIC_DISABLE_ONBOARDING flag and the driver.js dependency.
@hhvrc
hhvrc requested a balanced review from Copilot October 20, 2026 19:46
@hhvrc hhvrc self-assigned this Oct 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dceb3f35-da94-45a6-a00f-743305b46026
Commits

Reviewing files that changed from the base of the PR and between 913781f and c6d1601.

Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 16
  • .env
  • package.json
  • src/app.css
  • src/env.ts
  • src/hooks.client.ts
  • src/lib/state/auth-state.svelte.ts
  • src/lib/tour/onboarding-state.ts
  • src/lib/tour/welcome-tour.ts
  • src/lib/utils/legacy-storage-cleanup.ts
  • src/routes/(app)/settings/connections/+page.svelte
  • src/routes/(app)/shares/user/+layout.svelte
  • src/routes/(app)/shockers/own/+page.svelte
  • src/routes/+layout.server.ts
  • src/routes/+layout.svelte
  • src/routes/WelcomeScreen.svelte
  • src/worker-configuration.d.ts
Files with no reviewable changes: 9
  • package.json
  • src/env.ts
  • src/app.css
  • .env
  • src/routes/+layout.svelte
  • src/lib/tour/welcome-tour.ts
  • src/lib/tour/onboarding-state.ts
  • src/lib/state/auth-state.svelte.ts
  • src/routes/WelcomeScreen.svelte

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The pull request removes the welcome screen, onboarding state, and interactive welcome tour. It removes related configuration and tour targets, then adds client initialization cleanup for two legacy localStorage keys.

Changes: Onboarding and welcome-tour removal

Layer / File(s) Summary
Remove welcome screen and onboarding state
src/lib/tour/onboarding-state.ts, src/routes/+layout.server.ts, src/routes/+layout.svelte, src/routes/WelcomeScreen.svelte, .env, src/env.ts, src/worker-configuration.d.ts
The server layout no longer returns welcome-screen state, and the client layout no longer renders the welcome screen. The onboarding-state module and related environment setting declarations are removed.
Remove tour behavior and integration
src/lib/tour/welcome-tour.ts, src/lib/state/auth-state.svelte.ts, src/routes/(app)/settings/connections/+page.svelte, src/routes/(app)/shares/user/+layout.svelte, src/routes/(app)/shockers/own/+page.svelte, src/app.css, package.json
The interactive tour and login prompt are removed. Tour target attributes, driver.js styling, and the driver.js dependency are also removed.
Clean up legacy onboarding storage
src/lib/utils/legacy-storage-cleanup.ts, src/hooks.client.ts
Client initialization removes os.welcomeVersion and os.tourCompletedVersion from localStorage. Storage errors are ignored.

Priority: Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Suggested reviewers: lucheart

Merge Risk: Minimal · up to c6d16

The welcome screen and tour are removed, and legacy browser storage is cleaned up where available. No material merge risk was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main changes: removal of the welcome screen and onboarding tour.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 4 files. (3 skipped: 3 unsupported.)

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
openshock-app-dev c6d1601 Commit Preview URL

Branch Preview URL
Oct 28 2026, 03:06 PM

@hhvrc
hhvrc merged commit 9c5f384 into develop Oct 28, 2026
14 checks passed
@hhvrc
hhvrc deleted the chore/remove-welcome-screen branch October 28, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants