Repository navigation
Split newer-toolchain compatibility fixes from Arm64 readiness - #1096
yeelam-gordon wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Merge conflicts have been detected on this PR, please resolve. |
|
Thanks for separating these compatibility fixes! Two concerns currently block this: TrackedObjectBBox.cpp is always built, but its protobuf generation/linking is still OpenCV-only; and the spherical tests expect zero angles on every FFmpeg version, dropping nonzero round-trip coverage. We need to preserve OpenCV-disabled builds and angle checks where supported. This also needs a rebase and coordination with #1088 to avoid duplicate capability implementations. |
|
Thanks again for this work! While testing newer FFmpeg compatibility on our
Please preserve the nonzero-angle assertions where supported. They pass with our older FFmpeg 4.2.x build. For affected versions, we should separately verify the angles written into the MP4 and account for the reader defect, rather than expect zero on every version. We’re keeping the spherical changes separate while investigating this. The earlier OpenCV-disabled build concerns also remain outstanding. |
Adapt the focused MagickCore linkage fix from #1096 (head 37a2106). Windows requires direct linkage for the core functions used by the image readers and writers. Retain the existing fallback for older CMake packages. Co-authored-by: Gordon Lam (SH) (from Dev Box) <yeelam@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This PR contains the non-Arm64-specific compatibility fixes that were previously bundled into #1089 while validating the Windows Arm64 CLANGARM64 toolchain.
Scope in this PR:
This is a prerequisite split so that #1089 can stay narrow and Arm64-specific (CI lanes, package lock, architecture validator, and native-process oracle coverage).