Repository navigation
Apply database migrations when the API starts - #100
Merged
Merged
Conversation
Docker Compose and a bare om serve previously came up with an empty schema, so the console asked for a manual om migrate even though the image already contains the SQL. Pending files now apply before listen, and an explicit migrate remains for Postgres-only use. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
om serveapplies pending migrations before it listens, so Docker Compose and a firstom servecreate the schema without a separate./om migrate.schema_migrations.OM_AUTO_MIGRATE=false(Helmapi.autoMigrate) leaves schema changes to an explicitom migrate. The Helm init container still runsom migratefirst.serveand init-container runs. Each file and its version row commit together.om scanand the other CLI commands still do not migrate. Useom migratewhen Postgres is up and the API is not.Test plan
docker compose up -don an empty volume, then open the console without runningom migratedatabase schema is currentOM_AUTO_MIGRATE=falseleaves a fresh database uninitialized untilom migrate./om migrateon an already-migrated database printsDatabase schema is current.OM_AUTO_MIGRATEset to"true"and the migrate init container is still presentMade with Cursor