You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Pin the Health Connect delete-gate test to Health Connect (fails on macOS) - #685
health_workout_export_delete_gate_test ("a failed delete does not write a duplicate on top of it") fails on every Mac and passes in CI.
The exportWorkout delete-then-write group tests the Health Connect reading of a false delete, and its comment assumed "the host VM is neither iOS nor macOS". But HealthExporter.isApple is Platform.isIOS || Platform.isMacOS, and flutter test on a Mac runs on a macOS host VM. There isApple is true, the exporter takes the HealthKit branch (where a false delete is the documented empty-range answer and the write goes ahead, by design), and the test's Health Connect expectation fails. CI runs on ubuntu-latest, so it never sees it; a contributor on a Mac sees a red test unrelated to their change.
The app is fine on both platforms. Only the test was host-dependent.
What changes
lib/health/health_export.dart: a @visibleForTesting static bool? isAppleOverride, read first by isApple. null (the default, and always in the app) keeps the real platform check, so production behaviour is unchanged. Same pattern as ScreenWake.platformOverride in lib/gps/screen_wake.dart.
test/health_workout_export_delete_gate_test.dart: the group pins isAppleOverride = false in setUp and resets it in tearDown, so it tests Health Connect on every host.
Tests
test/health_workout_export_delete_gate_test.dart: 11/11 pass on macOS (was 10/11).
flutter analyze: no issues.
flutter test --concurrency=1: 7010 passed, 28 skipped, 8 failed. The 8 are the ones fix main's test run: missing translations and gallery case #683 fixes (ui2_tokens gallery, russian_localization, russian_review_findings, settings_report_l10n es/fr/hi/zh, thai_l10n); this test is no longer among them.
Not related to #683, which fixes the other red tests on main (translations, gallery); this one is a macOS-only failure #683 doesn't cover.
Stabilize Health Connect delete-gate coverage across development and CI environments.
Bug Fixes:
Make the Health Connect delete-gate test pass consistently on macOS by preventing host-platform-dependent behavior.
Enhancements:
Add a test-only override for platform-store selection while preserving production platform detection.
Tests:
Pin the delete-then-write tests to Health Connect and restore the platform selection after each test.
Summary by CodeRabbit
Chores
No user-facing changes in this release. Apple-platform detection behavior remains unchanged in normal use; the update only affects how that behavior can be overridden during testing.
The `exportWorkout delete-then-write` group tests the Health Connect
reading of a false delete, and assumed a non-Apple host. flutter test
on a Mac runs on a macOS host VM, where HealthExporter.isApple is true:
the exporter takes the HealthKit branch (a false delete is the
documented empty-range answer and the write proceeds, by design) and
"a failed delete does not write a duplicate" fails. CI runs on Linux,
so only contributors on a Mac saw it.
Add a @VisibleForTesting HealthExporter.isAppleOverride (null = the
real platform, so the app is unchanged), the same pattern as
ScreenWake.platformOverride, and pin it to false in that group.
No actionable comments were generated in the recent review.
Walkthrough
HealthExporter.isApple now uses a nullable test override when set. Otherwise, it checks whether the platform is iOS or macOS.
Changes: Apple platform detection
Layer / File(s)
Summary
Apple platform override lib/health/health_export.dart
isApple returns the test override when it is set. A new nullable, visible-for-testing field provides the override. When it is null, the platform check uses the iOS and macOS platform values.
The test now selects the Health Connect behavior on macOS without changing the default platform check. No merge-blocking risk was identified.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly describes the host-dependent Health Connect test fix and identifies the macOS failure it addresses.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 69341a6 and 7382f7e.
Files ignored due to path filters: 1
test/health_workout_export_delete_gate_test.dart is excluded by !test/**
Files selected for processing: 1
lib/health/health_export.dart
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Why
health_workout_export_delete_gate_test("a failed delete does not write a duplicate on top of it") fails on every Mac and passes in CI.The
exportWorkout delete-then-writegroup tests the Health Connect reading of afalsedelete, and its comment assumed "the host VM is neither iOS nor macOS". ButHealthExporter.isAppleisPlatform.isIOS || Platform.isMacOS, andflutter teston a Mac runs on a macOS host VM. ThereisAppleis true, the exporter takes the HealthKit branch (where afalsedelete is the documented empty-range answer and the write goes ahead, by design), and the test's Health Connect expectation fails. CI runs onubuntu-latest, so it never sees it; a contributor on a Mac sees a red test unrelated to their change.The app is fine on both platforms. Only the test was host-dependent.
What changes
lib/health/health_export.dart: a@visibleForTesting static bool? isAppleOverride, read first byisApple. null (the default, and always in the app) keeps the real platform check, so production behaviour is unchanged. Same pattern asScreenWake.platformOverrideinlib/gps/screen_wake.dart.test/health_workout_export_delete_gate_test.dart: the group pinsisAppleOverride = falseinsetUpand resets it intearDown, so it tests Health Connect on every host.Tests
test/health_workout_export_delete_gate_test.dart: 11/11 pass on macOS (was 10/11).flutter analyze: no issues.flutter test --concurrency=1: 7010 passed, 28 skipped, 8 failed. The 8 are the ones fix main's test run: missing translations and gallery case #683 fixes (ui2_tokens gallery, russian_localization, russian_review_findings, settings_report_l10n es/fr/hi/zh, thai_l10n); this test is no longer among them.Not related to #683, which fixes the other red tests on main (translations, gallery); this one is a macOS-only failure #683 doesn't cover.
🤖 Generated with Claude Code
Summary by Sourcery
Stabilize Health Connect delete-gate coverage across development and CI environments.
Bug Fixes:
Enhancements:
Tests:
Summary by CodeRabbit