Repository navigation
feat(wms): set default maxscaledenominator - #141
Merged
Merged
Conversation
kad-marchal
previously approved these changes
Oct 29, 2026
kad-marchal
left a comment
There was a problem hiding this comment.
Tests are still red, but changes lgtm
kad-marchal
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A degenerate request (very large bounding box combined with very small width/height) can cause high CPU usage in Mapserver. Setting a (high) default for the max scale denominator provides a workaround for this issue, since it forces Mapserver not to try rendering features beyond a certain zoom. For specific use cases, it is still possible to set a higher max scale denominator explicitly in a WMS CR.
Type of change
Checklist: