Repository navigation
Faster service lookups after a signature edit - #568
Merged
AJenbo merged 1 commit intoNov 12, 2026
Merged
Conversation
Building the container index confirms the configurator files, and a lookup made while confirming one asks for the index again. Nothing built meanwhile is kept, so every such lookup built the whole index again, nested as deep as the files being confirmed. Keep each index a thread builds while confirming files, keyed by those files, and reuse it for the next lookup made while the same files are being confirmed: the answers stay the same, and the index is built once per set of files being confirmed instead of once per lookup. Assisted-by: claude-code/claude-opus-5-5
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speeds up the first service lookup after an edit that changes a method signature, in a workspace with Symfony PHP configuration. Building the container index confirms the configuration's calls, and every lookup made while confirming one built the whole index again. The index is now built once per configuration file being confirmed, with the same answers.
In the repository root, which holds the Symfony and Drupal playgrounds, going to the definition of a Drupal plugin ID 2 seconds after such an edit takes about 1.1 s instead of 2.2 to 3.4 s. On Drupal core 11.4 and on the
redirectandflagmodules,analyzereports exactly whatmainreports, and the Drupal and Symfony completion benchmarks pass.How to test: open the repository root with this branch's build and open
examples/drupal/web/modules/custom/acme/src/Controller/GreetingController.php. InNoteCounter.phpnext to it, changecount(): inttocount(): ?int, then go to the definition of'acme_greeting_block'inblock().Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,examples/). Not applicable: no documented behaviour changes.config-schema.json). Not applicable: this PR adds or changes no setting.the changes and why they are needed.
the changelog, and other user-facing content, and removed or corrected
anything inaccurate, unclear, or unnecessary.