Skip to content

Fix 104 and 1097 Emergency Contacts and Start Call issue - #462

Open
vanitha1822 wants to merge 5 commits into
release-3.13.0from
nd/vs/104_issues_fix
Open

vanitha1822 wants to merge 5 commits into
release-3.13.0from
nd/vs/104_issues_fix

fix: align firebase and welcome sms tests with current code

a60d08c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Oct 27, 2026 in 49s

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 440 in src/main/java/com/iemr/common/service/notification/NotificationServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'com.fasterxml.jackson.databind.JsonMappingException' which is a subclass of 'com.fasterxml.jackson.core.JsonProcessingException'.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AaF71gHtCb8NoYRngNWd&open=AaF71gHtCb8NoYRngNWd&pullRequest=462

Check warning on line 49 in src/main/java/com/iemr/common/service/notification/NotificationService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'com.fasterxml.jackson.databind.JsonMappingException' which is a subclass of 'com.fasterxml.jackson.core.JsonProcessingException'.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AaF71gFjCb8NoYRngNWc&open=AaF71gFjCb8NoYRngNWc&pullRequest=462

Check warning on line 95 in src/main/java/com/iemr/common/service/welcomeSms/WelcomeBenificarySmsServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AaF71gDVCb8NoYRngNWb&open=AaF71gDVCb8NoYRngNWb&pullRequest=462

Check warning on line 90 in src/main/java/com/iemr/common/service/welcomeSms/WelcomeBenificarySmsServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AaF71gDVCb8NoYRngNWW&open=AaF71gDVCb8NoYRngNWW&pullRequest=462

Check warning on line 90 in src/main/java/com/iemr/common/service/welcomeSms/WelcomeBenificarySmsServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AaF71gDVCb8NoYRngNWZ&open=AaF71gDVCb8NoYRngNWZ&pullRequest=462

Check warning on line 106 in src/test/java/com/iemr/common/service/welcomeSms/WelcomeBenificarySmsServiceImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify".

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AaF88r0gCRnYTt1RJ2SN&open=AaF88r0gCRnYTt1RJ2SN&pullRequest=462

Check warning on line 95 in src/main/java/com/iemr/common/service/welcomeSms/WelcomeBenificarySmsServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AaF71gDVCb8NoYRngNWY&open=AaF71gDVCb8NoYRngNWY&pullRequest=462

Check warning on line 92 in src/main/java/com/iemr/common/service/welcomeSms/WelcomeBenificarySmsServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AaF71gDVCb8NoYRngNWX&open=AaF71gDVCb8NoYRngNWX&pullRequest=462

Check warning on line 92 in src/main/java/com/iemr/common/service/welcomeSms/WelcomeBenificarySmsServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AaF71gDVCb8NoYRngNWa&open=AaF71gDVCb8NoYRngNWa&pullRequest=462