feat: add UserSettingsTabProps interface for user account settings - #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
user.settings.tabextension point: a tab a plugin can register on the current user's own Account/Profile settings page, for per-user preferences (as opposed toadmin.page's instance-wide scope orproject.settings.tab's per-project scope).src/extension-points.ts: newUserSettingsTabProps extends BaseExtensionProps { userId: string }and"user.settings.tab"added to the extension point list/union. Theapiclient injected here has noprojectId(global scope, same asadmin.page) — routes are expected to be scoped by the authenticated caller (e.g./me/...-style plugin routes).src/index.ts: exportUserSettingsTabProps.First consumer:
paca-plugin-smtp's per-user "which events email me" preferences tab on the profile page.Test plan
npm run typecheckcleannpm run buildclean