Repository navigation
chore: mark Bukkit commands as obsolete - #14281
Conversation
|
I did not see the previous PR so I am just gonna leave my opinion here. In my opinion, I feel like users who already use those classes and methods are not gonna see those annotations and a later deprecation would, to them, appear to be just as out of the blue as it would be now. I don't think these classes are gonna be removed any time soon anyway, but if you want to push users towards new API I think an actual deprecation would do much more than an obsoletion. |
Doc94
left a comment
There was a problem hiding this comment.
Its a good start, i know people can ignore Obsolete but that already happen with Experimental or even Deprecate (see the damage modifier enum...)
So not hurt mark obsolete in favor of more updated solutions
|
While i do think this is laying a good foundation for a future deprecation of these methods, i do not believe this is enough. as @DerEchtePilz correctly pointed out, |
|
I like this a lot more. Bukkit commands are such an integral part of the API that I believe immediate deprecation is too unpredictable and sudden. Unless you regularily follow conversation in the #paper-dev channel or similar places, you likely be entirely unaware that the use of this API is discouraged. IMO the order should be:
Also ideally #11378, #11891 and #13163 would be fixed before a deprecation. |
kennytv
left a comment
There was a problem hiding this comment.
command aliases aren't really obsolete
|
I've gone ahead and fixed the wrong Javadoc tag and de-obsoleted the command aliases methods from |
Upstream has released updates that appear to apply and compile correctly Paper Changes: PaperMC/Paper@a15fed9c Update Gradle to 9.8 and paperweight to beta.24 PaperMC/Paper@08ca088b Count skipped inbound packets for rate limiting PaperMC/Paper#14305 PaperMC/Paper@d289ae1d Mark Bukkit commands as obsolete PaperMC/Paper#14281 PaperMC/Paper@a0919613 Add back mob peaceful despawn override PaperMC/Paper@f6862603 Skip styledLines in ItemLore hashcode and equals PaperMC/Paper@b23b7258 Pass on to Vanilla fixers if needed PaperMC/Paper@640efeea Make CraftWorld#isChunkGenerated use BLOCKING priority PaperMC/Paper@5cbb5d6f Update leafpile to 1.2.4 PaperMC/Paper#14310 PaperMC/Paper@d3ee2cfc Avoid entity nbt load logic when loading in full entity chunk PaperMC/Paper@f4eb9c2e Add chunkScanner implementation to ChunkMap PaperMC/Paper@8c95c89a Avoid default HIGHER priority for getChunkFutureMainThread PaperMC/Paper@0fdc0885 Rebase fixups
…kit commands - Paper 26.2 stable 127 -> 129; 26.3 alpha 32 -> 133; Purpur 26.3 2639 -> 2642; Folia still 26.2 build 7 beta - Document the 26.3 obsolescence of the Bukkit command system (PaperMC/Paper#14281) with both documented replacements: BasicCommand + registerCommand, and Brigadier via LifecycleEvents.COMMANDS - Update paperweight-userdev to 2.0.0-beta.24 - Record that the 26.3 Javadoc lags the builds (reported build 49 while builds were at 133) - Sync SKILL.md, references, both READMEs and the blog draft with the new snapshot
This PR is an alternative of #14227, whose goal is the complete deprecation of Bukkit commands.
Part of the backlash on that PR, partly also by maintainers, was that deprecation is a fairly strong thing to do out of the blue, and they should be marked obsolete first. Whilst I believe deprecation to be perfectly fine, I've decided to open a second PR to make it as obsolete.
I will keep the deprecation PR open, so that it may be considered in the future (maybe 26.4?), with this PR serving as a transition layer.