Repository navigation
Fit the phone marking tools on narrower iPhones - #142
Merged
Merged
Conversation
Since Edit source joined the bottom marking bar, its ten buttons needed about 400px. On 390–402px phones (iPhone 15–17) the bar scrolled sideways with nothing to show it and cut Redo in half; on 375px phones two buttons were hidden. Up to 430px the buttons are now 32px wide and the separators narrower, so the whole bar, about 360px, shows on every current iPhone.
Member
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Since #119 added Edit source to the bottom marking bar on phones, its ten buttons (magic pen | pen, region, sticky note, strike, edit source, select | undo, redo | collapse) need about 400px. Measured in the demo:
The bar scrolled sideways with no hint. Up to 430px, buttons are now 32px wide instead of 35px (height stays 36px) and separators have 1px margins instead of 2px. That makes the bar about 360px on every current iPhone. The collapsed pill keeps its own width.
How it was checked
check-review-pdf-appearance(pointer target sizes, phone dock positioning) andcheck-pdf-tools(phone collapsible bottom capsule) pass locally.npm run build,npm run build:playground