Skip to content

fix: integrate reader preloading and saved animation controls - #103

Merged
Eoic merged 12 commits into
developmentfrom
fix/pin-reader-interruption-fix
Oct 29, 2026
Merged

Eoic merged 12 commits into
developmentfrom
fix/pin-reader-interruption-fix

Conversation

@Eoic

@Eoic Eoic commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Issue and requirements

Closes #102. Supports FR-3_1 and FR-3_2. Depends on PapyrusReader/reader#14.

Summary

Connect the existing saved Page turn animation preference to the reader and persist changes from reading settings. The compact Slide / None dropdown controls EPUB button, keyboard and swipe turns, including chapter boundaries.

Pin the manifest and lockfile to reader c9f566fde4de3bfd1dce6df1fd6d17bae6aaf114. This revision keeps opening feedback consistent, buffers five spreads ahead, retains previous pages, prepares neighboring sections independently and warms nearby illustrations. It also preserves the actual displayed location after interrupted or immediate page turns. Rapid slider navigation now keeps only the latest queued destination, cancels obsolete EPUB preparation, ignores late errors and holds the thumb steady during dragging.

Contents now reuses the reader's standard panel header, matching Reading settings in typography, height, padding, close button and divider.

Safe-area insets now retain the page color during chapter transitions and typography reflows, while new document loading uses the host surface.

Testing

  • Locked Git dependency resolution and 32 focused panel, navigation and theme tests passed in an isolated checkout against the exact new SHA. Header regressions compare typography, geometry, divider and dismissal in light, dark and e-ink themes. Earlier adapter, session and location-persistence tests passed for the preceding reader revisions.
  • Client formatting, analysis and four web-bootstrap tests passed.
  • All 231 reader tests passed, including buffering, reverse navigation, blocked-neighbor preparation and immediate-turn and latest-seek regressions. Reader/example analysis, example tests/web build and browser smoke passed.
  • Local path overrides remain preserved and excluded from commits.

UI evidence

Desktop and phone settings were visually inspected. The reader uses a compact Slide / None dropdown without explanatory text. Loading tests verify consistent position, theme and a single indicator through opening and pagination.

Compatibility and migration

Uses the existing page_turn_animation preference. No migration or version bump.

Notes

Merge reader PR #14 first. GitHub CI is running. Cold jumps into unprepared content still require yielding layout.

Checklist

  • Branch, commits and title follow repository conventions.
  • Changes are scoped to reader integration and its dependency pin.
  • Regression tests cover persistence and navigation behavior.
  • Formatting, analysis and relevant tests pass locally.
  • UI evidence and migration notes are included.
  • No credentials or unrelated generated files are included.
  • Current development is included.

Copilot AI balanced review requested due to automatic review settings October 28, 2026 22:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T22:49:08.304061Z 3f766b1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 24.48980% with 37 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/lib/main.dart 17.77% 37 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Eoic Eoic changed the title fix: pin reader interruption review fix fix: persist page-turn animation preference and update reader Oct 29, 2026
@Eoic Eoic changed the title fix: persist page-turn animation preference and update reader fix: integrate reader preloading and saved animation controls Oct 29, 2026
@Eoic
Eoic enabled auto-merge October 29, 2026 21:51
@Eoic
Eoic merged commit 502a1e9 into development Oct 29, 2026
7 checks passed
@Eoic
Eoic deleted the fix/pin-reader-interruption-fix branch October 29, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate reader loading and motion fixes with persisted preferences

2 participants