Skip to content

Integrate the merged reader’s rendered-page coverage - #122

Merged
Eoic merged 1 commit into
developmentfrom
fix/integrate-reader-page-coverage
Nov 2, 2026
Merged

Eoic merged 1 commit into
developmentfrom
fix/integrate-reader-page-coverage

Conversation

@Eoic

@Eoic Eoic commented Nov 2, 2026

Copy link
Copy Markdown
Member

The Statistics redesign was still using the older reader Git pin, so packaged clients could not use individual rendered EPUB page identities. Pin both the manifest and lockfile to fa667ae96c64e2d1d80c06e83d326265673abc75, the merged result of PapyrusReader/reader#19.

The actual EPUB navigation integration test now requires two distinct, non-estimated page records after two page views. It no longer accepts the chapter-based calculation.

Fixes #121. Follows #120 and contributes to FR-5_1 (PapyrusReader/docs#34).

Validation in a separate checkout with no dependency override:

  • flutter pub get --enforce-lockfile resolves the merged reader from Git.
  • Full client suite: 2,088 passed, 19 skipped.
  • Analysis and formatting pass, along with all 17 JavaScript checks.

The local development reader override is preserved and excluded from the commit. No app version bump or deployment is included.

Copilot AI balanced review requested due to automatic review settings November 2, 2026 21:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T21:58:49.993069Z fa46bf2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Eoic
Eoic enabled auto-merge November 2, 2026 21:58
@Eoic
Eoic merged commit 0088a82 into development Nov 2, 2026
9 checks passed
@Eoic
Eoic deleted the fix/integrate-reader-page-coverage branch November 2, 2026 22:08
@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate rendered-page coverage from the merged reader

2 participants